ubuntu-touch-coreapps-reviewers team mailing list archive

[Michael Zanetti <michael.zanetti@xxxxxxxxxxxxx>]

Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/fix-missing-checkbox into lp:reminders-app with lp:~mzanetti/reminders-app/workaround-oxide-race as a prerequisite.

Commit message:
Fix the missing icon for unchecked checkboxes in EditNoteView

Requested reviews:
  Ubuntu Notes app developers (notes-app-dev)

For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/fix-missing-checkbox/+merge/270750
-- 
Your team Ubuntu Notes app developers is requested to review the proposed merge of lp:~mzanetti/reminders-app/fix-missing-checkbox into lp:reminders-app.

=== modified file 'src/libqtevernote/utils/enmldocument.cpp'
--- src/libqtevernote/utils/enmldocument.cpp	2015-06-14 23:34:29 +0000
+++ src/libqtevernote/utils/enmldocument.cpp	2015-09-10 21:06:23 +0000
@@ -236,7 +236,7 @@
 
                 if (type == TypeRichText) {
                     writer.writeStartElement("img");
-                    writer.writeAttribute("src", checked ? "image://theme/select" : "../images/unchecked.svg");
+                    writer.writeAttribute("src", checked ? "image://theme/select" : "image://theme/select-none");
                     writer.writeAttribute("height", QString::number(gu(2)));
                 } else if (type == TypeHtml){
                     writer.writeStartElement("input");