ubuntu-touch-coreapps-reviewers team mailing list archive

[Michael Zanetti <michael.zanetti@xxxxxxxxxxxxx>]

Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/fix-textfields into lp:reminders-app with lp:~rpadovani/reminders-app/predictiveTextTagInsertion as a prerequisite.

Commit message:
fix predictive text input

Requested reviews:
  Ubuntu Notes app developers (notes-app-dev)

For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/fix-textfields/+merge/270760
-- 
Your team Ubuntu Notes app developers is requested to review the proposed merge of lp:~mzanetti/reminders-app/fix-textfields into lp:reminders-app.

=== modified file 'src/app/qml/components/EditTagsDialog.qml'
--- src/app/qml/components/EditTagsDialog.qml	2015-09-10 22:50:16 +0000
+++ src/app/qml/components/EditTagsDialog.qml	2015-09-10 22:50:16 +0000
@@ -98,7 +98,7 @@
                 border.width: units.dp(1)
                 border.color: "black"
                 height: Math.min(5, tagsListView.count) * units.gu(4)
-                visible: textField.text.length > 0 && (textField.focus || tagsListView.focus)
+                visible: (textField.text.length > 0 || textField.inputMethodComposing) && (textField.focus || tagsListView.focus)
 
                 ListView {
                     id: tagsListView

=== modified file 'src/app/qml/ui/NotebooksPage.qml'
--- src/app/qml/ui/NotebooksPage.qml	2015-07-25 01:52:22 +0000
+++ src/app/qml/ui/NotebooksPage.qml	2015-09-10 22:50:16 +0000
@@ -207,7 +207,7 @@
 
             Button {
                 text: i18n.tr("OK")
-                enabled: nameTextField.text
+                enabled: nameTextField.text || nameTextField.inputMethodComposing
                 onClicked: {
                     renameNotebookDialog.accepted(nameTextField.text)
                     PopupUtils.close(renameNotebookDialog)