← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~gang65/ubuntu-clock-app/ubuntu-clock-stopwatch-runtime-timezone-fix into lp:ubuntu-clock-app

To: mp+270396@xxxxxxxxxxxxxxxxxx
From: Nekhelesh Ramananthan <krnekhelesh@xxxxxxxxx>
Date: Fri, 11 Sep 2015 10:05:06 -0000
In-reply-to: <20150908125321.6816.64585.launchpad@ackee.canonical.com>
Reply-to: mp+270396@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

I also think we should move the initialization of the StopwatchEngine{} to the StopwatchPage.qml and just expose the running property to the mainPage.qml. 
-- 
https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-stopwatch-runtime-timezone-fix/+merge/270396
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.

References

[Merge] lp:~gang65/ubuntu-clock-app/ubuntu-clock-stopwatch-runtime-timezone-fix into lp:ubuntu-clock-app
From: Bartosz Kosiorek, 2015-09-08