ubuntu-touch-coreapps-reviewers team mailing list archive

[Victor Thompson <victor.thompson@xxxxxxxxx>]

Victor Thompson has proposed merging lp:~vthompson/ubuntu-weather-app/reboot-day-details-width into lp:ubuntu-weather-app/reboot.

Commit message:
* Make the first column of the day delegate extra info wider to accommodate other languages.

Requested reviews:
  Ubuntu Weather Developers (ubuntu-weather-dev)

For more details, see:
https://code.launchpad.net/~vthompson/ubuntu-weather-app/reboot-day-details-width/+merge/270918

* Make the first column of the day delegate extra info wider to accommodate other languages.

For instance, this is what the expanded info looks like in German on a Nexus 4: http://i.imgur.com/wzGeC6y.png
-- 
Your team Ubuntu Weather Developers is requested to review the proposed merge of lp:~vthompson/ubuntu-weather-app/reboot-day-details-width into lp:ubuntu-weather-app/reboot.

=== modified file 'app/components/ForecastDetailsDelegate.qml'
--- app/components/ForecastDetailsDelegate.qml	2015-07-25 21:53:40 +0000
+++ app/components/ForecastDetailsDelegate.qml	2015-09-13 22:26:03 +0000
@@ -39,7 +39,7 @@
     Label {
         id: forecastLabel
         elide: Text.ElideRight
-        width: units.gu(14)
+        width: units.gu(18)
     }
     
     Label {

=== modified file 'debian/changelog'
--- debian/changelog	2015-09-05 22:54:51 +0000
+++ debian/changelog	2015-09-13 22:26:03 +0000
@@ -25,6 +25,8 @@
   * Get the condition text to be translated from the OWM API. (LP: #1487793)
   * Add a Network Error State Component for when a connection error takes place.
   * Allow the LocationsPage to be flickable. (LP: #1490044)
+  * Make the first column of the day delegate extra info wider to accomodate other
+    languages.
 
   [ Andrew Hayzen ]
   * Add mocked locations for autopilot and add a test using the data