← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

Re: [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-05 into lp:ubuntu-filemanager-app

 

I had to promote a modification to fix a bug about generating the signal which will activate the Authentication dialog.

The modification was:
         if (model.isBrowsable) {
79	-            if (model.isReadable && model.isExecutable) {
80	+            console.log("browsable path="+model.filePath+" isRemote="+model.isRemote+" needsAuthentication="+model.needsAuthentication)
81	+            if ((model.isReadable && model.isExecutable) ||
82	+                (model.isRemote && model.needsAuthentication) //in this case it is necessary to generate the signal needsAuthentication()
83	

Also added the properties on the model:
    * isRemote
    * isLocal
    * needsAuthentication
-- 
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-ui-05/+merge/270339
Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app.


References