ubuntu-touch-coreapps-reviewers team mailing list archive

[Victor Thompson <victor.thompson@xxxxxxxxx>]

Victor Thompson has proposed merging lp:~vthompson/ubuntu-weather-app/fix-1490040 into lp:ubuntu-weather-app/reboot.

Commit message:
* Show the bottom loading animation (LoadingIndicator) on the LocationsPage.

Requested reviews:
  Ubuntu Weather Developers (ubuntu-weather-dev)
Related bugs:
  Bug #1490040 in Ubuntu Weather App: "[reboot] Locations list page should show bouncing animation"
  https://bugs.launchpad.net/ubuntu-weather-app/+bug/1490040

For more details, see:
https://code.launchpad.net/~vthompson/ubuntu-weather-app/fix-1490040/+merge/271741

* Show the bottom loading animation (LoadingIndicator) on the LocationsPage.
-- 
Your team Ubuntu Weather Developers is requested to review the proposed merge of lp:~vthompson/ubuntu-weather-app/fix-1490040 into lp:ubuntu-weather-app/reboot.

=== modified file 'app/ui/LocationsPage.qml'
--- app/ui/LocationsPage.qml	2015-09-10 23:43:49 +0000
+++ app/ui/LocationsPage.qml	2015-09-19 22:57:09 +0000
@@ -258,6 +258,10 @@
         }
     }
 
+    LoadingIndicator {
+        id: loadingIndicator
+    }
+
     Loader {
         active: locationsList === null || locationsList.length === 0
         anchors {

=== modified file 'debian/changelog'
--- debian/changelog	2015-09-14 19:59:26 +0000
+++ debian/changelog	2015-09-19 22:57:09 +0000
@@ -26,6 +26,7 @@
   * Add a Network Error State Component for when a connection error takes place.
   * Allow the LocationsPage to be flickable. (LP: #1490044)
   * Make sure the text elides on the LocationsPage and the AddLocationPage. (LP: #1469460)
+  * Show the bottom loading animation (LoadingIndicator) on the LocationsPage. (LP: #1490040)
 
   [ Andrew Hayzen ]
   * Add mocked locations for autopilot and add a test using the data