ubuntu-touch-coreapps-reviewers team mailing list archive

[Victor Thompson <victor.thompson@xxxxxxxxx>]

Review: Needs Fixing

I noticed a few small things, but otherwise this lgtm.

Diff comments:

> 
> === added file 'tests/manual/music_app/jobs/playlists.pxu'
> --- tests/manual/music_app/jobs/playlists.pxu	1970-01-01 00:00:00 +0000
> +++ tests/manual/music_app/jobs/playlists.pxu	2015-09-23 01:02:50 +0000
> @@ -0,0 +1,66 @@
> +id: playlists/create-playlists
> +plugin: manual
> +_summary: Test create playlist
> +estimated_duration: 600
> +_description
> +    Test create playlist
> +    1. Open music app
> +    2. Navigate to playlist view
> +        Expect empty playlist:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-101416.png
> +    3. Tap "+" button in top right
> +        Expect "New Playlist" dialog:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-204544.png
> +    4. Tap in the input field
> +        Expect to see the OSK appear:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-205144.png
> +    5. Type "Best songs"
> +    6. Press Create
> +        Expect to see empty playlist:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-205248.png
> +
> +id: playlists/add-tracks-to-playlist
> +plugin: manual
> +_summary: Test add tracks to playlist
> +estimated_duration: 600
> +_description
> +    Test add tracks to playlist
> +    1. Navigate to Songs view
> +    2. Slide left a song
> +        Expect to see buttons revealed:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-205354.png
> +    3. Tap last icon (add to playlist)
> +        Expect to be taken to "Select playlist" view:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-205514.png
> +    4. Select previously created playlist "Best songs"
> +        Expect to be taken back to previous view:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-205552.png
> +    5. Navigate to albums view
> +    6. Tap on an album
> +        Expect to see the individual album view:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-205713.png
> +    7. Long press on a track
> +        Expect multi-select boxes and buttons to appear:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-205819.png
> +    8. Tap multiple songs
> +    9. Tap 'burger' menu in the top right, choose "add to playlist"

The word "add" should be capitalized.

> +        Expect to be taken to the "Select playlist" view:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-205923.png
> +    10. Tap previously create playlist
> +         Expect to be taken back to individual album view:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-210010.png
> +    11. Navigate to Playlist view
> +    12. Tap previously created playlist
> +         Expect to see songs previously selected:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-210333.png
> +
> +id: playlists/remove-playlist
> +plugin: manual
> +_summary: Test removing playlist
> +estimated_duration: 600
> +_description
> +    Test removing playlist
> +    1. Navigate to Playlist view
> +    2. Tap previously created playlist
> +    3. Tap rubbish bin in top toolbar
> +        Expect to get a confirmation prompt:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-210424.png
> +    4. Tap 'Remove' button
> +        Expect playlist to be removed:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-210520.png
> +
> +id: playlists/tab-persist
> +plugin: manual
> +_summary: Test tab index is persists a restart
> +estimated_duration: 600
> +_description
> +    Test tab index is persists a restart
> +    1. Start the app and switch to a tab (eg playlists)
> +    2. Close the app and restart it
> +        Expect the app to start on the same tab
> 
> === added file 'tests/manual/music_app/jobs/queue.pxu'
> --- tests/manual/music_app/jobs/queue.pxu	1970-01-01 00:00:00 +0000
> +++ tests/manual/music_app/jobs/queue.pxu	2015-09-23 01:02:50 +0000
> @@ -0,0 +1,36 @@
> +id: queue/deletion-music
> +plugin: manual
> +_summary: Test deletion of music from queue
> +estimated_duration: 600
> +_description
> +    Test deletion of music from queue
> +    1. Open music app
> +    2. Select an album and play all
> +        Expect the album to start playing and that single album to be in the queue
> +    3. Delete the entire album from the device
> +        Expect the view to be 'popped' back to the Albums view
> +        Expect the music to be stopped and the queue to be empty
> +
> +id: queue/sd-card-remove
> +plugin: manual
> +_summary: Test removing SD Card during playback
> +estimated_duration: 600
> +_description
> +    Test removing SD Card during playback

The other SD card test says that this test is only valid for krillin or a device with an SD card. Perhaps the same should be said here. Also, mentioning krillin specifically isn't probably the best idea in terms of maintainability.

> +    1. Add some songs to an SD card
> +    2. Queue up an album which is on the SD card
> +    3. Start playing tracks from the queue
> +    4. Remove the SD Card
> +        Expect tracks which are no longer accessible should disappear from the queue
> +
> +id: queue/restart
> +plugin: manual
> +_summary: Test queue persists a restart
> +estimated_duration: 600
> +_description
> +    Test queue persists a restart
> +    1. Start the app
> +    2. Add a few albums to the queue
> +    3. Take note of the queue and current track
> +    4. Restart the app
> +        Expect the queue to be restored and the same track to be selected


-- 
https://code.launchpad.net/~ahayzen/music-app/add-manual-tests-001/+merge/272050
Your team Music App Developers is subscribed to branch lp:music-app.