ubuntu-touch-coreapps-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~gang65/ubuntu-clock-app/ubuntu-clock-app-australia-display-fix into lp:ubuntu-clock-app

To: mp+274183@xxxxxxxxxxxxxxxxxx
From: Nekhelesh Ramananthan <krnekhelesh@xxxxxxxxx>
Date: Tue, 13 Oct 2015 16:41:19 -0000
In-reply-to: <20151012204425.17191.11547.launchpad@ackee.canonical.com>
Reply-to: mp+274183@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Disapprove

As per the inline comments, I do think that this is a upstream QT issue IMO. I also commented about it in the bug report at https://bugs.launchpad.net/ubuntu-clock-app/+bug/1384739/comments/5. By patching it downstream in the clock app, I fear we might break other locales without proper testing. 

Personally I don't like introducing downstream patches when the correct solution breaks in certain use-cases due to upstream bugs.


-- 
https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-app-australia-display-fix/+merge/274183
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.

References

[Merge] lp:~gang65/ubuntu-clock-app/ubuntu-clock-app-australia-display-fix into lp:ubuntu-clock-app
From: Bartosz Kosiorek, 2015-10-12