← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

Re: [Merge] lp:~gang65/ubuntu-clock-app/ubuntu-clock-app-australia-display-fix into lp:ubuntu-clock-app

 

> Ok. I understand that it needs extensive testing.
> 
> Can we move this patch to the next Clock release then?

It would be better if the fix for this issue came from QtUbuntu [1] rather than patching it in the clock app. Downstream QT Patches are done in QtUbuntu (and upstream after a while). Can you talk to Timo Jyrinki who usually does this? You can find him in #ubuntu-app-devel, #ubuntu-touch etc under the nickname Mirv. 

Let's not add these kind of patches in clock app due to upstream issues *unless* it is a High/Critical issue that affects a large portion of users. Instead we should convince upstream to fix these issues.

Testing is just one aspect of it. It just adds the headache of maintaining that patch ourselves once we add it.

[1] https://launchpad.net/qtubuntu
-- 
https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-app-australia-display-fix/+merge/274183
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.


References