← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

[Merge] lp:~gang65/ubuntu-weather-app/ubuntu-weather-app-message-text-fix into lp:ubuntu-weather-app/reboot

 

Bartosz Kosiorek has proposed merging lp:~gang65/ubuntu-weather-app/ubuntu-weather-app-message-text-fix into lp:ubuntu-weather-app/reboot.

Commit message:
Change message text according to Ubuntu UX comment (LP: #1493466)

Requested reviews:
  Ubuntu Weather Developers (ubuntu-weather-dev)
Related bugs:
  Bug #1493466 in Ubuntu Weather App: "[reboot][weather app] Hard to translate sentence in Ubuntu Weather App"
  https://bugs.launchpad.net/ubuntu-weather-app/+bug/1493466

For more details, see:
https://code.launchpad.net/~gang65/ubuntu-weather-app/ubuntu-weather-app-message-text-fix/+merge/274840

Change message text according to Ubuntu UX comment (LP: #1493466)
-- 
Your team Ubuntu Weather Developers is requested to review the proposed merge of lp:~gang65/ubuntu-weather-app/ubuntu-weather-app-message-text-fix into lp:ubuntu-weather-app/reboot.
=== modified file 'app/components/NetworkErrorStateComponent.qml'
--- app/components/NetworkErrorStateComponent.qml	2015-08-28 21:54:22 +0000
+++ app/components/NetworkErrorStateComponent.qml	2015-10-19 03:13:06 +0000
@@ -54,7 +54,7 @@
             anchors {
                 horizontalCenter: parent.horizontalCenter
             }
-            text: i18n.tr("Ubuntu suggests you check your network settings and try again.")
+            text: i18n.tr("Please check your network settings and try again.")
             width: parent.width
             wrapMode: Text.WordWrap
         }

=== modified file 'debian/changelog'
--- debian/changelog	2015-10-18 15:51:11 +0000
+++ debian/changelog	2015-10-19 03:13:06 +0000
@@ -62,6 +62,9 @@
   * Create autopilot test which changes temperature units (LP: #1452493)
   * Create autopilot test which changest wind units (LP: #1452496)
 
+  [ Bartosz Kosiorek ]
+  * Change message text according to Ubuntu UX comment (LP: #1493466)
+
  -- Victor Thompson <victor.thompson@xxxxxxxxx>  Mon, 01 Jun 2015 20:11:23 -0500
 
 ubuntu-weather-app (2.1) UNRELEASED; urgency=medium

=== modified file 'po/com.ubuntu.weather.pot'
--- po/com.ubuntu.weather.pot	2015-10-15 10:39:42 +0000
+++ po/com.ubuntu.weather.pot	2015-10-19 03:13:06 +0000
@@ -8,7 +8,7 @@
 msgstr ""
 "Project-Id-Version: ubuntu-weather-app\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2015-10-15 11:39+0100\n"
+"POT-Creation-Date: 2015-10-19 05:06+0200\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <LL@xxxxxx>\n"
@@ -87,7 +87,7 @@
 msgstr ""
 
 #: ../app/components/NetworkErrorStateComponent.qml:57
-msgid "Ubuntu suggests you check your network settings and try again."
+msgid "Please check your network settings and try again."
 msgstr ""
 
 #: ../app/components/NetworkErrorStateComponent.qml:63
@@ -130,7 +130,7 @@
 msgid "Locations"
 msgstr ""
 
-#: ../app/ui/LocationsPage.qml:106
+#: ../app/ui/LocationsPage.qml:109
 msgid "Current Location"
 msgstr ""
 


Follow ups