ubuntu-touch-coreapps-reviewers team mailing list archive

[Timo Jyrinki <timo.jyrinki@xxxxxxxxxxxxx>]

Timo Jyrinki has proposed merging lp:~timo-jyrinki/dropping-letters/drop_audiorole_usage into lp:dropping-letters.

Commit message:
Drop audioRole usage as it shouldn't be used in this use case

Requested reviews:
  Dropping Letters developers (dropping-letters-devs)
Related bugs:
  Bug #1493851 in qtubuntu-media (Ubuntu): "Port to upstreamed versions of Audio Role patch"
  https://bugs.launchpad.net/ubuntu/+source/qtubuntu-media/+bug/1493851

For more details, see:
https://code.launchpad.net/~timo-jyrinki/dropping-letters/drop_audiorole_usage/+merge/275150
-- 
Your team Dropping Letters developers is requested to review the proposed merge of lp:~timo-jyrinki/dropping-letters/drop_audiorole_usage into lp:dropping-letters.

=== modified file 'dropping-letters.qml'
--- dropping-letters.qml	2014-09-26 22:56:07 +0000
+++ dropping-letters.qml	2015-10-21 09:28:20 +0000
@@ -331,21 +331,18 @@
                     id: click
                     source: "407__tictacshutup__click-1-off-click.ogg"
                     autoLoad: volume.supportsMedia
-                    audioRole: MediaPlayer.alert
                 }
 
                 Audio {
                     id: success
                     source: "80921__justinbw__buttonchime02up.ogg"
                     autoLoad: volume.supportsMedia
-                    audioRole: MediaPlayer.alert
                 }
 
                 Audio {
                     id: failure
                     source: "106727__kantouth__cartoon-bing-low.ogg"
                     autoLoad: volume.supportsMedia
-                    audioRole: MediaPlayer.alert
                 }
 
                 Audio {
@@ -355,7 +352,6 @@
                     onStopped: {
                         flipable.flipped = false
                     }
-                    audioRole: MediaPlayer.alert
                 }
 
                 Rectangle {