ubuntu-touch-coreapps-reviewers team mailing list archive

[Bartosz Kosiorek <gang65@xxxxxxxxxxxxxx>]

Review: Needs Information

I tested it and it is working correctly for me on BQ E4.5 device.
It is nice improvement especially for QT 5.5 upgrade

One inline question below.

Do you think it could help in missing volume changes, during alarm preview?:
https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-volume-preview/+merge/264783

Ricardo Salveti already investigated that issue, unfortunately without success.


Diff comments:

> 
> === added file 'app/components/AlarmAudio.qml'
> --- app/components/AlarmAudio.qml	1970-01-01 00:00:00 +0000
> +++ app/components/AlarmAudio.qml	2015-10-21 12:33:11 +0000
> @@ -0,0 +1,35 @@
> +import QtQuick 2.4
> +
> +Item {
> +    id: root
> +    property string source: ""
> +    readonly property alias playbackState: priv.playbackState
> +
> +    function play() {
> +        priv.audio.play();
> +    }
> +    function stop() {
> +        priv.audio.stop();
> +    }
> +
> +    QtObject {
> +        id: priv
> +        property var audio: null
> +        property var playbackState: null
> +    }
> +
> +    Binding {
> +        target: priv
> +        property: "playbackState"
> +        value: priv.audio ? priv.audio.playbackState : 0
> +    }
> +
> +    Component.onCompleted: {
> +        try {
> +            priv.audio = Qt.createQmlObject("import QtMultimedia 5.5; Audio { source: root.source; audioRole: MediaPlayer.AlarmRole }", priv)
> +        } catch(err) {
> +            print("QtMultimedia 5.5 not installed. Falling back to 5.4.");

Generally in Clock application we are using "console.log".
Why did you use print() here?

> +            priv.audio = Qt.createQmlObject("import QtMultimedia 5.4; Audio { source: root.source; audioRole: MediaPlayer.alarm }", priv)
> +        }
> +    }
> +}


-- 
https://code.launchpad.net/~mzanetti/ubuntu-clock-app/detect-qtmm-version/+merge/275177
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.