ubuntu-touch-coreapps-reviewers team mailing list archive

[Albert Astals Cid <albert.astals@xxxxxxxxxxxxx>]

Review: Needs Fixing



Diff comments:

> 
> === added file 'app/components/AlarmAudio.qml'
> --- app/components/AlarmAudio.qml	1970-01-01 00:00:00 +0000
> +++ app/components/AlarmAudio.qml	2015-10-22 10:43:07 +0000
> @@ -0,0 +1,35 @@
> +import QtQuick 2.4
> +
> +Item {
> +    id: root
> +    property string source: ""
> +    readonly property alias playbackState: priv.playbackState
> +
> +    function play() {
> +        priv.audio.play();
> +    }
> +    function stop() {
> +        priv.audio.stop();
> +    }
> +
> +    QtObject {
> +        id: priv
> +        property var audio: null
> +        property var playbackState: null
> +    }
> +
> +    Binding {
> +        target: priv
> +        property: "playbackState"
> +        value: priv.audio ? priv.audio.playbackState : 0
> +    }
> +
> +    Component.onCompleted: {
> +        try {
> +            priv.audio = Qt.createQmlObject("import QtMultimedia 5.5; Audio { source: root.source; audioRole: MediaPlayer.AlarmRole }", priv)

This should be 5.6 since our packages have the feature backport from 5.6

> +        } catch(err) {
> +            console.log("QtMultimedia 5.5 not installed. Falling back to 5.4.");
> +            priv.audio = Qt.createQmlObject("import QtMultimedia 5.4; Audio { source: root.source; audioRole: MediaPlayer.alarm }", priv)
> +        }
> +    }
> +}


-- 
https://code.launchpad.net/~mzanetti/ubuntu-clock-app/detect-qtmm-version/+merge/275177
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.