ubuntu-touch-coreapps-reviewers team mailing list archive

[Bartosz Kosiorek <gang65@xxxxxxxxxxxxxx>]

Review: Needs Fixing

Some inline comments

Diff comments:

> 
> === modified file 'app/components/BlurredHeader.qml'
> --- app/components/BlurredHeader.qml	2015-05-03 16:22:31 +0000
> +++ app/components/BlurredHeader.qml	2015-10-21 00:09:41 +0000
> @@ -17,7 +17,7 @@
>   */
>  
>  import QtQuick 2.4
> -import Ubuntu.Components 1.2
> +import Ubuntu.Components 1.3
>  import Ubuntu.Components.ListItems 1.0 as ListItem

ListItems should be also upgraded to 1.3

>  
>  ListItem.Standard {
> 
> === modified file 'app/components/Dialog/ContentHubWaitDialog.qml'
> --- app/components/Dialog/ContentHubWaitDialog.qml	2015-05-03 16:22:31 +0000
> +++ app/components/Dialog/ContentHubWaitDialog.qml	2015-10-21 00:09:41 +0000
> @@ -18,7 +18,7 @@
>   */
>  
>  import QtQuick 2.4
> -import Ubuntu.Components 1.2
> +import Ubuntu.Components 1.3
>  import Ubuntu.Components.Popups 1.0

Popups should be also upgraded to 1.3

>  import "../"
>  
> 
> === modified file 'app/components/Dialog/EditPlaylistDialog.qml'
> --- app/components/Dialog/EditPlaylistDialog.qml	2015-05-03 16:22:31 +0000
> +++ app/components/Dialog/EditPlaylistDialog.qml	2015-10-21 00:09:41 +0000
> @@ -18,7 +18,7 @@
>   */
>  
>  import QtQuick 2.4
> -import Ubuntu.Components 1.2
> +import Ubuntu.Components 1.3
>  import Ubuntu.Components.Popups 1.0

Popups should be also upgraded to 1.3

>  import QtQuick.LocalStorage 2.0
>  import "../../logic/meta-database.js" as Library
> 
> === modified file 'app/components/Dialog/NewPlaylistDialog.qml'
> --- app/components/Dialog/NewPlaylistDialog.qml	2015-05-03 16:22:31 +0000
> +++ app/components/Dialog/NewPlaylistDialog.qml	2015-10-21 00:09:41 +0000
> @@ -18,7 +18,7 @@
>   */
>  
>  import QtQuick 2.4
> -import Ubuntu.Components 1.2
> +import Ubuntu.Components 1.3
>  import Ubuntu.Components.Popups 1.0

Popups should be also upgraded to 1.3

>  import QtQuick.LocalStorage 2.0
>  import "../../logic/playlists.js" as Playlists
> 
> === modified file 'app/components/Dialog/RemovePlaylistDialog.qml'
> --- app/components/Dialog/RemovePlaylistDialog.qml	2015-05-03 16:22:31 +0000
> +++ app/components/Dialog/RemovePlaylistDialog.qml	2015-10-21 00:09:41 +0000
> @@ -18,7 +18,7 @@
>   */
>  
>  import QtQuick 2.4
> -import Ubuntu.Components 1.2
> +import Ubuntu.Components 1.3
>  import Ubuntu.Components.Popups 1.0

Popups should be also upgraded to 1.3

>  import QtQuick.LocalStorage 2.0
>  import "../../logic/meta-database.js" as Library


-- 
https://code.launchpad.net/~vthompson/music-app/music-uc1.3/+merge/267889
Your team Music App Developers is subscribed to branch lp:music-app.