← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

Re: [Merge] lp:~mzanetti/ubuntu-clock-app/drop-audioRole into lp:ubuntu-clock-app

 

> W dniu 22.10.2015 o 14:52, Jim Hodapp pisze:
> > Review: Needs Information
> >
> > I would like to better understand why you're dropping the role completely
> instead of moving to the NotificationRole? As it stands right now, it'll use
> the old MultimediaRole at the media-hub and PulseAudio layer. So if you have
> music playing in music-app and then you go into the clock-app to preview the
> alarm sound, it should actually pause the background music instead of the
> duck-in effect. If that's what you desire then this is fine.
> 
> See the alternative proposal from the description.
> 
> In any case, what you describe does not work today, the preview plays
> over music of reduced volume.

Yes indeed, and this was the original design. We still want this in my opinion unless the design team says otherwise.
> 
> I don't think it should be Notification (or current - alert) anyway,
> it's an alarm, after all? 

I agree, but we are discussing only the alarm preview in this MR. Unless the actual alarm uses the same audio role as the preview does?

> The counter argument is that if you want
> Silent mode to keep the alarm preview silent, but then you can't change
> the actual alarm volume with hardware buttons while playing the preview.
> And you shouldn't be able to, or you will think the volume you're
> changing is alarm, when in fact, it's the ringtone/alert volume.

-- 
https://code.launchpad.net/~mzanetti/ubuntu-clock-app/drop-audioRole/+merge/275179
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.


Follow ups

References