← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

Re: [Merge] lp:~qqworini/ubuntu-rssreader-app/uitk-1_3 into lp:ubuntu-rssreader-app

 

Please see inline comments!

Diff comments:

> === modified file 'manifest.json.in'
> --- manifest.json.in	2015-07-17 14:42:42 +0000
> +++ manifest.json.in	2015-10-24 07:10:31 +0000
> @@ -1,7 +1,7 @@
>  {
>      "architecture": "@CLICK_ARCH@",
>      "description": "Rss Reader application",
> -    "framework": "ubuntu-sdk-15.04",

You forget to change the same line "manifest.json.4pro"

> +    "framework": "ubuntu-sdk-15.04.1-qml",
>      "hooks": {
>          "shorts": {
>              "apparmor": "shorts.apparmor",


-- 
https://code.launchpad.net/~qqworini/ubuntu-rssreader-app/uitk-1_3/+merge/275620
Your team Ubuntu Shorts Developers is requested to review the proposed merge of lp:~qqworini/ubuntu-rssreader-app/uitk-1_3 into lp:ubuntu-rssreader-app.


References