ubuntu-touch-coreapps-reviewers team mailing list archive

[Roman Shchekin <mrqtros@xxxxxxxxx>]

Roman Shchekin has proposed merging lp:~mrqtros/ubuntu-rssreader-app/uitk13-few-fixes into lp:ubuntu-rssreader-app with lp:~qqworini/ubuntu-rssreader-app/uitk-1_3 as a prerequisite.

Commit message:
* Manifest version fro PRO
* BottomEdgeTabs fixed
* Regex for image parsing

Requested reviews:
  Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration
  Ubuntu Shorts Developers (ubuntu-rssreader-dev)
  Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot): continuous-integration

For more details, see:
https://code.launchpad.net/~mrqtros/ubuntu-rssreader-app/uitk13-few-fixes/+merge/275625

* Manifest version fro PRO
* BottomEdgeTabs fixed
* Regex for image parsing
-- 
Your team Ubuntu Shorts Developers is requested to review the proposed merge of lp:~mrqtros/ubuntu-rssreader-app/uitk13-few-fixes into lp:ubuntu-rssreader-app.

=== modified file 'manifest.json.4pro'
--- manifest.json.4pro	2015-07-21 19:41:58 +0000
+++ manifest.json.4pro	2015-10-24 13:58:25 +0000
@@ -11,5 +11,5 @@
     },
     "version": "1.0.6",
     "maintainer": "Roman Shchekin <mrqtros@xxxxxxxxx>",
-    "framework": "ubuntu-sdk-15.04"
+    "framework": "ubuntu-sdk-15.04.1-qml"
 }

=== modified file 'shorts/qml/components/BottomEdgeTabs.qml'
--- shorts/qml/components/BottomEdgeTabs.qml	2015-10-24 13:58:24 +0000
+++ shorts/qml/components/BottomEdgeTabs.qml	2015-10-24 13:58:25 +0000
@@ -164,7 +164,7 @@
         z: 1
         width: tipLabel.paintedWidth + units.gu(6)
         height: bottomEdge.tipHeight + units.gu(1)
-        color: bottomEdgeTipColor //color: "#C9C9C9"
+        backgroundColor: bottomEdgeTipColor //color: "#C9C9C9"
 
         Label {
             id: tipLabel

=== modified file 'shorts/qml/utils/imgSeparator.js'
--- shorts/qml/utils/imgSeparator.js	2015-07-04 08:38:18 +0000
+++ shorts/qml/utils/imgSeparator.js	2015-10-24 13:58:25 +0000
@@ -1,31 +1,25 @@
-function separate(rss_content) {
-    var image_array = []
-
-
-    image_array = rss_content.split("<img")
-    // console.log("SPLIT");
-
-    image_array.shift() ;
-
-    for (var i=0; i<image_array.length; i++)
-    {
-        try {
-            image_array[i] = image_array[i].split('src=')[1].split(/"|"/)[1]
-            if (image_array[i].indexOf("//") === 0)
-                image_array[i] = "http:" + image_array[i]
-        }
-        catch(err) {
-            ; // do nothing
-        }
+.pragma library
+
+function separate(content) {
+    var result = []
+    var rx = /<img.*?src="(.*?)"/g
+
+    var e = rx.exec(content)
+    while (e) {
+        // Some simple checks here.
+        if (e[1].indexOf("http") === 0)
+            result.push(e[1])
+
+        e = rx.exec(content)
     }
 
-    return image_array
+    return result
 }
 
 function getFirstImage(content) {
     var imgArr = separate(content)
 
-    if (imgArr.length > 0)
+    if (imgArr.length)
         return imgArr[0]
 
     return null