ubuntu-touch-coreapps-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app

To: Carlos Jose Mazieri <carlos.mazieri@xxxxxxxxx>
From: Arto Jalkanen <ajalkane@xxxxxxxxx>
Date: Tue, 27 Oct 2015 20:05:41 -0000
In-reply-to: <20151021110423.17503.46426.launchpad@ackee.canonical.com>
Reply-to: mp+275164@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

getStat()'s return value is always casted to StatReturn, so it would seem to me that it'd be better to  have getStat() rturn always StatReturn so that the casting would be in one place and not dispersed around code.

-- 
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05/+merge/275164
Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app.

References

[Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app
From: Carlos Jose Mazieri, 2015-10-21