ubuntu-touch-coreapps-reviewers team mailing list archive
-
ubuntu-touch-coreapps-reviewers team
-
Mailing list archive
-
Message #05636
Re: [Merge] lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-math-2.4-upgrade into lp:ubuntu-calculator-app
Review: Approve
Thank you for the patch, Bartosz! :)
I gave it a try and couldn't manage to find any regressions. :p I can confirm that the bug this is supposed to fix is indeed fixed and that the autopilot tests ran fine on my machine.
Looking at math.js's issue list on Github, I can also not find any regression in version 2.4 that would be relevant to our case.
Therefore, I'd say, let's get this in. :)
Good job, Bartosz!
--
https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-math-2.4-upgrade/+merge/274958
Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app.
References