ubuntu-touch-coreapps-reviewers team mailing list archive

[Andrew Hayzen <ahayzen@xxxxxxxxx>]

Review: Needs Information

One inline comment

Diff comments:

> 
> === modified file 'app/ui/NowPlaying.qml'
> --- app/ui/NowPlaying.qml	2015-10-28 01:05:33 +0000
> +++ app/ui/NowPlaying.qml	2015-11-03 03:55:33 +0000
> @@ -54,6 +56,12 @@
>          }
>      }
>  
> +    onVisibleChanged: {
> +        if (!visible) {
> +            head.sections.selectedIndex = 0

Would this not cause the sections to switch when you do Add To Playlist?
Also why is this needed? isn't the NowPlaying page created on the fly when we do 
mainPageStack.push(Qt.resolvedUrl("ui/NowPlaying.qml"), {})

> +        }
> +    }
> +
>      // Ensure that the listview has loaded before attempting to positionAt
>      function ensureListViewLoaded() {
>          if (queueListLoader.item.count === trackQueue.model.count) {


-- 
https://code.launchpad.net/~vthompson/music-app/music-uc1.3-now-playing-fix-1447428/+merge/275635
Your team Music App Developers is subscribed to branch lp:music-app.