ubuntu-touch-coreapps-reviewers team mailing list archive

[Alan Pope  <alan@xxxxxxxxxx>]

Alan Pope  has proposed merging lp:~popey/ubuntu-weather-app/update-readme-owm-key into lp:ubuntu-weather-app.

Commit message:
Describe how to get a key in the README. Mention this in the key.js

Requested reviews:
  Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration
  Ubuntu Weather Developers (ubuntu-weather-dev)

For more details, see:
https://code.launchpad.net/~popey/ubuntu-weather-app/update-readme-owm-key/+merge/276974

Describe how to get a key in the README. Mention this in the key.js
-- 
Your team Ubuntu Weather Developers is requested to review the proposed merge of lp:~popey/ubuntu-weather-app/update-readme-owm-key into lp:ubuntu-weather-app.

=== modified file 'README'
--- README	2015-01-22 21:56:55 +0000
+++ README	2015-11-09 10:38:47 +0000
@@ -4,6 +4,15 @@
     https://wiki.ubuntu.com/Touch/CoreApps/Weather
     https://wiki.ubuntu.com/Touch/CoreApps/DevelopmentGuide
 
+Note: The OpenWeatherMap service now requires an API key where previously
+      it did not. FOSS developers can register for a free API key
+      which needs to be put into app/data/keys.js for the app to 
+      function correctly. Do not commit branches with the key in place
+      as a centrally managed key is injected at build time.
+
+      See http://openweathermap.org/faq#error401 for details and
+      http://openweathermap.org/appid to obtain a personal key.
+
 The following essential packages are required to develop this app:
 - ubuntu-sdk (see http://developer.ubuntu.com/start)
 - intltool - run the `sudo apt-get install intltool` command for installation

=== modified file 'app/data/keys.js'
--- app/data/keys.js	2015-10-14 23:31:23 +0000
+++ app/data/keys.js	2015-11-09 10:38:47 +0000
@@ -1,2 +1,2 @@
 var twcKey = "";
-var owmKey = "";  // goto http://openweathermap.org/appid to get a personal API key
+var owmKey = "";  // See README for details on how to obtain a personal API key