ubuntu-touch-coreapps-reviewers team mailing list archive

[Bartosz Kosiorek <gang65@xxxxxxxxxxxxxx>]

Review: Needs Fixing

Some small inline comment.

I will intense test it later today.

Diff comments:

> 
> === modified file 'app/upstreamcomponents/PageWithBottomEdge.qml'
> --- app/upstreamcomponents/PageWithBottomEdge.qml	2015-01-28 21:32:05 +0000
> +++ app/upstreamcomponents/PageWithBottomEdge.qml	2015-11-09 14:34:26 +0000
> @@ -105,7 +105,7 @@
>              edgeLoader.item.active = true
>              page.pageStack.push(edgeLoader.item)
>              if (edgeLoader.item.flickable) {
> -                edgeLoader.item.flickable.contentY = -page.header.height
> +                //edgeLoader.item.flickable.contentY = -page.header.height

If it is not used anymore, then just delete it.

>                  edgeLoader.item.flickable.returnToBounds()
>              }
>              if (edgeLoader.item.ready)


-- 
https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/bumpToolkit/+merge/277012
Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app.