ubuntu-touch-coreapps-reviewers team mailing list archive

[Bartosz Kosiorek <gang65@xxxxxxxxxxxxxx>]

Review: Needs Fixing

Thanks Riccardo.
I noticed that following warnings are appearing:
file:///home/kosiorek/dev/core/bumpToolkit/app/upstreamcomponents/PageWithBottomEdge.qml:144:5: QML UbuntuShape: 'color' is deprecated. Use 'backgroundColor', 'secondaryBackgroundColor' and 'backgroundMode' instead.


and

uses confusion which is the active page that sets the title and actions.
file:///home/kosiorek/dev/core/bumpToolkit/app/ubuntu-calculator-app.qml:253:9: QML PageWithBottomEdge: Binding loop detected for property "height"
file:///home/kosiorek/dev/core/bumpToolkit/app/ubuntu-calculator-app.qml:253:9: QML PageWithBottomEdge: Binding loop detected for property "height"
file:///home/kosiorek/dev/core/bumpToolkit/app/ubuntu-calculator-app.qml:538:13: QML ScrollableView: Binding loop detected for property "contentHeight"
file:///home/kosiorek/dev/core/bumpToolkit/app/ubuntu-calculator-app.qml:253:9: QML PageWithBottomEdge: Binding loop detected for property "flickable"

and error during scrolling selected entries:
file:///home/kosiorek/dev/core/bumpToolkit/app/ui/ScrollableView.qml:37: TypeError: Cannot read property 'y' of null

Could you please try to fix that?

There are also errors:
file:///usr/lib/x86_64-linux-gnu/qt5/qml/Ubuntu/Components/1.3/PageWrapperUtils.js:90: TypeError: Cannot read property 'createObject' of null


-- 
https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/bumpToolkit/+merge/277012
Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app.