← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

[Merge] lp:~mzanetti/reminders-app/new-notebook-input into lp:reminders-app

 

Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/new-notebook-input into lp:reminders-app.

Commit message:
Fix the input field for new notebook in regard to predictive OSK

Requested reviews:
  Ubuntu Notes app developers (notes-app-dev)

For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/new-notebook-input/+merge/277437
-- 
Your team Ubuntu Notes app developers is requested to review the proposed merge of lp:~mzanetti/reminders-app/new-notebook-input into lp:reminders-app.
=== modified file 'src/app/qml/ui/NotebooksPage.qml'
--- src/app/qml/ui/NotebooksPage.qml	2015-09-21 16:32:10 +0000
+++ src/app/qml/ui/NotebooksPage.qml	2015-11-13 12:13:53 +0000
@@ -164,20 +164,24 @@
                 id: cancelButton
                 anchors { left: parent.left; verticalCenter: parent.verticalCenter }
                 text: i18n.tr("Cancel")
+                activeFocusOnPress: false
                 onClicked: {
                     newNoteTitleTextField.text = "";
                     contentColumn.newNotebook = false
+                    newNoteTitleTextField.focus = false;
                 }
             }
             Button {
                 objectName: "saveButton"
+                activeFocusOnPress: false
                 anchors { right: parent.right; verticalCenter: parent.verticalCenter }
                 text: i18n.tr("Save")
-                enabled: newNoteTitleTextField.text.length > 0
+                enabled: newNoteTitleTextField.text.length > 0 || newNoteTitleTextField.inputMethodComposing
                 onClicked: {
-                    NotesStore.createNotebook(newNoteTitleTextField.text);
+                    NotesStore.createNotebook(newNoteTitleTextField.displayText);
                     newNoteTitleTextField.text = "";
                     contentColumn.newNotebook = false
+                    newNoteTitleTextField.focus = false;
                 }
             }
         }


Follow ups