ubuntu-touch-coreapps-reviewers team mailing list archive

[Victor Thompson <victor.thompson@xxxxxxxxx>]

Victor Thompson has proposed merging lp:~vthompson/music-app/more-uc1.3-updates into lp:music-app.

Commit message:
* Resolve FIXMEs/TODOs in main qml file

Requested reviews:
  Music App Developers (music-app-dev)

For more details, see:
https://code.launchpad.net/~vthompson/music-app/more-uc1.3-updates/+merge/277508

* Resolve FIXMEs/TODOs in main qml file

There may be more we can resolve as being fixed with the release of Ubuntu.Components 1.3.
-- 
Your team Music App Developers is requested to review the proposed merge of lp:~vthompson/music-app/more-uc1.3-updates into lp:music-app.

=== modified file 'app/music-app.qml'
--- app/music-app.qml	2015-10-28 01:05:33 +0000
+++ app/music-app.qml	2015-11-15 00:11:23 +0000
@@ -38,11 +38,8 @@
     id: mainView
 
     backgroundColor: styleMusic.mainView.backgroundColor
-    headerColor: styleMusic.mainView.headerColor
     theme.name: "Ubuntu.Components.Themes.SuruDark"
 
-    property bool useDeprecatedToolbar: false  // FIXME: keep SDK autopilot helpers happy
-
     // Startup settings
     Settings {
         id: startupSettings
@@ -267,10 +264,6 @@
         if (args.values.url) {
             uriHandler.process(args.values.url, true);
         }
-
-        // TODO: Workaround for pad.lv/1356779, force the theme's backgroundText color
-        // to work with the app's backgroundColor
-        Theme.palette.normal.backgroundText = "#81888888"
     }
 
     // VARIABLES

=== modified file 'debian/changelog'
--- debian/changelog	2015-11-03 02:44:19 +0000
+++ debian/changelog	2015-11-15 00:11:23 +0000
@@ -9,6 +9,7 @@
   * Update canned mediastore.db schema version from 8 to 9 (LP: #1511585).
   * Update canned mediastore.db schema version from 9 to 10.
   * Add directions for updating and debugging schema version changes.
+  * Resolve FIXMEs/TODOs in main qml file
 
   [ Andrew Hayzen ]
   * Switch to using the new uc1.3 listitems within the SDK