ubuntu-touch-coreapps-reviewers team mailing list archive

[Andrew Hayzen <ahayzen@xxxxxxxxx>]

Review: Needs Fixing

One inline comment, if pushNowPlaying() is called, it needs to be ensured that the Full View is selected as this could be called via uri-handler but in the queue view.

Diff comments:

> === modified file 'app/music-app.qml'
> --- app/music-app.qml	2015-10-28 01:05:33 +0000
> +++ app/music-app.qml	2015-11-05 01:17:31 +0000
> @@ -984,14 +979,9 @@
>              function pushNowPlaying()
>              {
>                  // only push if on a different page
> -                if (mainPageStack.currentPage.title !== i18n.tr("Now playing")
> -                        && mainPageStack.currentPage.title !== i18n.tr("Queue")) {
> +                if (mainPageStack.currentPage.title !== i18n.tr("Now playing")) {
>                      mainPageStack.push(Qt.resolvedUrl("ui/NowPlaying.qml"), {})
>                  }
> -
> -                if (mainPageStack.currentPage.title === i18n.tr("Queue")) {

This should be changed to
if (mainPageStack.currentPage.isListView === true) {
   mainPageStack.currentPage.isListView = false;  // ensure full view
}

> -                    mainPageStack.currentPage.isListView = false;  // ensure full view
> -                }
>              }
>          } // end of tabs
>      }


-- 
https://code.launchpad.net/~vthompson/music-app/music-uc1.3-now-playing-fix-1447428/+merge/275635
Your team Music App Developers is subscribed to branch lp:music-app.