ubuntu-touch-coreapps-reviewers team mailing list archive

[Roman Shchekin <mrqtros@xxxxxxxxx>]

Review: Approve

See my inline note (not important).

Diff comments:

> 
> === modified file 'src/plugin/libreofficetoolkit-qml-plugin/plugin.cpp'
> --- src/plugin/libreofficetoolkit-qml-plugin/plugin.cpp	2015-10-05 20:53:25 +0000
> +++ src/plugin/libreofficetoolkit-qml-plugin/plugin.cpp	2015-11-13 17:32:36 +0000
> @@ -22,15 +22,17 @@
>  #include "lodocument.h"
>  #include "loview.h"
>  #include "lopartsmodel.h"
> +#include "loerror.h"
>  
>  void LOPlugin::registerTypes(const char *uri)
>  {
>      Q_ASSERT(uri == QLatin1String("DocumentViewer.LibreOffice"));
>      
>      //@uri DocumentViewer.LibreOffice
> -    qmlRegisterType<LODocument>(uri, 1, 0, "Document");
> -    qmlRegisterType<LOView>(uri, 1, 0, "View");
> -    qmlRegisterUncreatableType<LOPartsModel>(uri, 1, 0, "PartsModel", "You shouldn't create LOPartsModel in QML");

I think that such indentation is redundant. In my opinion not all code should be aligned in columns because it will be like assemler ;)

> +    qmlRegisterType             <LODocument>        (uri, 1, 0, "Document");
> +    qmlRegisterType             <LOView>            (uri, 1, 0, "View");
> +    qmlRegisterUncreatableType  <LOPartsModel>      (uri, 1, 0, "PartsModel", "You shouldn't create LOPartsModel in QML");
> +    qmlRegisterUncreatableType  <LibreOfficeError>  (uri, 1, 0, "Error",      "Not creatable as an object, use only to retrieve error enums (e.g. LibreOffice.Error.DocumentNotFound)");
>  }
>  
>  void LOPlugin::initializeEngine(QQmlEngine *engine, const char *uri)


-- 
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/reboot-lok-error-detection/+merge/277295
Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app/reboot.