ubuntu-touch-coreapps-reviewers team mailing list archive

[Michael Zanetti <michael.zanetti@xxxxxxxxxxxxx>]

Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/no-2-cols-on-flo into lp:reminders-app.

Commit message:
workaround to disable the buggy two column mode on nexus 7 for now.

The whole 2-column logic currently is a self-made thing that is
subject to be replaced with the AdaptivePageLayout from the UITK.

Requested reviews:
  Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration
  Ubuntu Notes app developers (notes-app-dev)

For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/no-2-cols-on-flo/+merge/278129

workaround to disable the buggy two column mode on nexus 7 for now.        
                                                                 
The whole 2-column logic currently is a self-made thing that is  
subject to be replaced with the AdaptivePageLayout from the UITK.
-- 
Your team Ubuntu Notes app developers is requested to review the proposed merge of lp:~mzanetti/reminders-app/no-2-cols-on-flo into lp:reminders-app.

=== modified file 'src/app/qml/Reminders.qml'
--- src/app/qml/Reminders.qml	2015-11-02 20:26:37 +0000
+++ src/app/qml/Reminders.qml	2015-11-20 11:08:30 +0000
@@ -37,7 +37,7 @@
     objectName: "mainView"
     applicationName: "com.ubuntu.reminders"
 
-    property bool narrowMode: root.width < units.gu(80)
+    property bool narrowMode: root.width < units.gu(108)
     property var uri: undefined
 
     onNarrowModeChanged: {