ubuntu-touch-coreapps-reviewers team mailing list archive
-
ubuntu-touch-coreapps-reviewers team
-
Mailing list archive
-
Message #06131
[Merge] lp:~nikwen/ubuntu-calendar-app/remove-unnecessary-i18n-calls into lp:ubuntu-calendar-app
Niklas Wenzel has proposed merging lp:~nikwen/ubuntu-calendar-app/remove-unnecessary-i18n-calls into lp:ubuntu-calendar-app.
Commit message:
Remove unnecessary i18n.tr() calls
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
For more details, see:
https://code.launchpad.net/~nikwen/ubuntu-calendar-app/remove-unnecessary-i18n-calls/+merge/278228
Remove unnecessary i18n.tr() calls
Please note that I haven't tested this change.
--
Your team Ubuntu Calendar Developers is requested to review the proposed merge of lp:~nikwen/ubuntu-calendar-app/remove-unnecessary-i18n-calls into lp:ubuntu-calendar-app.
=== modified file 'DayView.qml'
--- DayView.qml 2015-02-18 19:27:20 +0000
+++ DayView.qml 2015-11-20 23:10:10 +0000
@@ -56,7 +56,7 @@
id:monthYear
objectName:"monthYearLabel"
fontSize: "x-large"
- text: i18n.tr(currentDay.toLocaleString(Qt.locale(),i18n.tr("MMMM yyyy")))
+ text: currentDay.toLocaleString(Qt.locale(),i18n.tr("MMMM yyyy"))
font.capitalization: Font.Capitalize
}
}
=== modified file 'MonthView.qml'
--- MonthView.qml 2015-09-05 05:33:38 +0000
+++ MonthView.qml 2015-11-20 23:10:10 +0000
@@ -57,7 +57,7 @@
// TRANSLATORS: this is a time formatting string,
// see http://qt-project.org/doc/qt-5/qml-qtqml-date.html#details for valid expressions.
// It's used in the header of the month and week views
- text: i18n.tr(currentMonth.toLocaleString(Qt.locale(),i18n.tr("MMMM yyyy")))
+ text: currentMonth.toLocaleString(Qt.locale(),i18n.tr("MMMM yyyy"))
font.capitalization: Font.Capitalize
}
}
Follow ups