ubuntu-touch-coreapps-reviewers team mailing list archive

[Stefano Verzegnassi <stefano92.100@xxxxxxxxx>]

Stefano Verzegnassi has proposed merging lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-error-detection-pt2 into lp:ubuntu-docviewer-app.

Commit message:
Error detection branch has been merged without a 'fix' as per diff inline comments. Not relevant stuff, just code styling.

Requested reviews:
  Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/lok-error-detection-pt2/+merge/278260

Error detection branch has been merged without a 'fix' as per diff inline comments. Not relevant stuff, just code styling.
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-error-detection-pt2 into lp:ubuntu-docviewer-app.

=== modified file 'src/plugin/libreofficetoolkit-qml-plugin/plugin.cpp'
--- src/plugin/libreofficetoolkit-qml-plugin/plugin.cpp	2015-11-11 19:59:15 +0000
+++ src/plugin/libreofficetoolkit-qml-plugin/plugin.cpp	2015-11-22 13:39:04 +0000
@@ -29,10 +29,10 @@
     Q_ASSERT(uri == QLatin1String("DocumentViewer.LibreOffice"));
     
     //@uri DocumentViewer.LibreOffice
-    qmlRegisterType             <LODocument>        (uri, 1, 0, "Document");
-    qmlRegisterType             <LOView>            (uri, 1, 0, "View");
-    qmlRegisterUncreatableType  <LOPartsModel>      (uri, 1, 0, "PartsModel", "You shouldn't create LOPartsModel in QML");
-    qmlRegisterUncreatableType  <LibreOfficeError>  (uri, 1, 0, "Error",      "Not creatable as an object, use only to retrieve error enums (e.g. LibreOffice.Error.DocumentNotFound)");
+    qmlRegisterType<LODocument>(uri, 1, 0, "Document");
+    qmlRegisterType<LOView>(uri, 1, 0, "View");
+    qmlRegisterUncreatableType<LOPartsModel>(uri, 1, 0, "PartsModel", "You shouldn't create LOPartsModel in QML");
+    qmlRegisterUncreatableType<LibreOfficeError>(uri, 1, 0, "Error", "Not creatable as an object, use only to retrieve error enums (e.g. LibreOffice.Error.DocumentNotFound)");
 }
 
 void LOPlugin::initializeEngine(QQmlEngine *engine, const char *uri)