ubuntu-touch-coreapps-reviewers team mailing list archive

[Bartosz Kosiorek <gang65@xxxxxxxxxxxxxx>]

Bartosz Kosiorek has proposed merging lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-profiling-doc-update into lp:ubuntu-calculator-app.

Commit message:
Add instruction how to enable profiling (workaround for LP: #1520551)

Requested reviews:
  Ubuntu Calculator Developers (ubuntu-calculator-dev)

For more details, see:
https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-profiling-doc-update/+merge/278791

Add instruction how to enable profiling (workaround for LP: #1520551)
-- 
Your team Ubuntu Calculator Developers is requested to review the proposed merge of lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-profiling-doc-update into lp:ubuntu-calculator-app.

=== modified file 'README'
--- README	2014-11-30 21:31:04 +0000
+++ README	2015-11-27 12:00:00 +0000
@@ -9,6 +9,7 @@
 
 # How to develop
 
+
 ## Calculation engine.
 
 Current calculation engine is math.js version 1.1.0. 
@@ -17,6 +18,7 @@
 
 The engine was sligtly modified to properly work with Ubuntu-Calculator-App.
 
+
 ## Style guide
 
 General idea above style guide is:
@@ -32,6 +34,7 @@
 Curent style guide for ubuntu-calculator-app is:
     https://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml
 
+
 ## Clean/Beautiful Code
 
 When you creating code, every function/variable name should be meaningful and has easy to understand form. The names should reveal intent of creator. With good names you even do not need an comments. The code is documentting itself. We should avoid comments if it is not necessary.
@@ -41,6 +44,7 @@
  * Clean Code: A Handbook of Agile Software Craftsmanship Paperback, by Robert C. Martin
  * Beautiful Code: Leading Programmers Explain How They Think, by Andy Oram
 
+
 ## Run the autopilot tests
 
 Prerequisites:
@@ -50,3 +54,30 @@
 
     cd tests/autopilot
     autopilot run ubuntu_calculator_app
+
+
+## Profiling calculator
+
+To successfuly run profiler on your device, you must modify ubuntu-calculator-app.apparmor file,
+and add "networking" policy group:
+
+ "policy_groups": [
+    "networking"
+ ],
+
+The bug was already submitted at:
+https://bugs.launchpad.net/ubuntu-sdk-ide/+bug/1520551
+
+Next you will need follow instruction:
+
+ 1. Connect your device to PC and make sure it is unlocked, and Developer Mode is enable
+ 2. Run Ubuntu SDK IDE
+ 3. Open Calculator project and generate Unix Makefiles for Arm.
+ 4. Select Analyze > QML Profiler 
+ 5. Select the Start button to start Calculator from the QML Profiler.
+ 6. After reproduce issue you must press Stop button.
+
+More information about profiling is available at:
+http://doc.qt.io/qtcreator/creator-qml-performance-monitor.html
+
+

=== modified file 'debian/changelog'
--- debian/changelog	2015-11-15 00:18:19 +0000
+++ debian/changelog	2015-11-27 12:00:00 +0000
@@ -3,6 +3,7 @@
   [ Bartosz Kosiorek ]
   * Fix evaluation of long complex numbers (LP: #1515600)
   * Upgrade math.js to version 2.4.2 to fix complex numbers formatting 
+  * Add instruction how to enable profiling (workaround for LP: #1520551)
 
  -- Bartosz Kosiorek <gang65@xxxxxxxxxxxxxx>  Thu, 12 Nov 2015 13:28:29 +0100