← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

Re: [Merge] lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-icon-fix into lp:ubuntu-calculator-app

 

Review: Needs Fixing

Seems the merge of my branch with trunk went wrong :/

Please see [0].

You need to drop your comments and replace iconName with

iconName: visualModel.selectedItems.count < visualModel.items.count ?
                                        "select" : "select-none"

See the diff of the commit linked to see how replace it, thanks

[0]: https://bazaar.launchpad.net/~rpadovani/ubuntu-calculator-app/dropCustomIcons/revision/237
-- 
https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-icon-fix/+merge/278818
Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app.