ubuntu-touch-coreapps-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~nikwen/ubuntu-calendar-app/fix-standalone-month-name-i18n into lp:ubuntu-calendar-app

To: Niklas Wenzel <nikwen.developer@xxxxxxxxx>
From: David Planella <david.planella@xxxxxxxxxx>
Date: Wed, 09 Dec 2015 14:55:45 -0000
In-reply-to: <20151203211822.7629.42035.launchpad@ackee.canonical.com>
Reply-to: mp+279509@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Information

Sorry, to be more specific:

- Qt.locale() should choose the right locale for you already for the standaloneMonthName, without needing qsTr()
- Does currentMonth.getFullYear() not need to be localized as well?
-- 
https://code.launchpad.net/~nikwen/ubuntu-calendar-app/fix-standalone-month-name-i18n/+merge/279509
Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app.

References

[Merge] lp:~nikwen/ubuntu-calendar-app/fix-standalone-month-name-i18n into lp:ubuntu-calendar-app
From: Niklas Wenzel, 2015-12-03