ubuntu-touch-coreapps-reviewers team mailing list archive

[Victor Thompson <victor.thompson@xxxxxxxxx>]

Victor Thompson has proposed merging lp:~vthompson/ubuntu-weather-app/fix-1521701 into lp:ubuntu-weather-app.

Commit message:
* Change translatable string from "rain" to "precipitation"

Requested reviews:
  Ubuntu Weather Developers (ubuntu-weather-dev)
Related bugs:
  Bug #1521701 in Ubuntu Weather App: "[weather app]Chance of rain shouldn't be used when the possible precipitation is snow or other"
  https://bugs.launchpad.net/ubuntu-weather-app/+bug/1521701

For more details, see:
https://code.launchpad.net/~vthompson/ubuntu-weather-app/fix-1521701/+merge/280379

* Change translatable string from "rain" to "precipitation"

This change still needs Design approval.
-- 
Your team Ubuntu Weather Developers is requested to review the proposed merge of lp:~vthompson/ubuntu-weather-app/fix-1521701 into lp:ubuntu-weather-app.

=== modified file 'app/components/DayDelegateExtraInfo.qml'
--- app/components/DayDelegateExtraInfo.qml	2015-11-02 21:28:34 +0000
+++ app/components/DayDelegateExtraInfo.qml	2015-12-12 03:43:31 +0000
@@ -48,10 +48,10 @@
     }
 
     ForecastDetailsDelegate {
-        id: chanceOfRainForecast
-        forecast: i18n.tr("Chance of rain")
+        id: chanceOfPrecipForecast
+        forecast: i18n.tr("Chance of precipitation")
         imageSource: "../graphics/extended-information_chance-of-rain.svg"
-        value: modelData.chanceOfRain
+        value: modelData.chanceOfPrecip
     }
 
     ForecastDetailsDelegate {

=== modified file 'app/components/ForecastDetailsDelegate.qml'
--- app/components/ForecastDetailsDelegate.qml	2015-11-02 21:28:34 +0000
+++ app/components/ForecastDetailsDelegate.qml	2015-12-12 03:43:31 +0000
@@ -20,7 +20,7 @@
 import Ubuntu.Components 1.3
 
 Row {
-    height: icon.height
+    height: forecastLabel.height
     spacing: units.gu(2)
     visible: value !== ""
 
@@ -39,6 +39,7 @@
     Label {
         id: forecastLabel
         elide: Text.ElideRight
+        wrapMode: Text.WordWrap
         width: units.gu(16)
     }
     

=== modified file 'app/ui/LocationPane.qml'
--- app/ui/LocationPane.qml	2015-11-02 21:28:34 +0000
+++ app/ui/LocationPane.qml	2015-12-12 03:43:31 +0000
@@ -153,7 +153,7 @@
             high: (data[tempUnits].tempMax !== undefined) ? Math.round(data[tempUnits].tempMax).toString() + settings.tempScale : "",
             image: (data.icon !== undefined && iconMap[data.icon] !== undefined) ? iconMap[data.icon] : "",
             condition: emptyIfUndefined(data.condition),
-            chanceOfRain: emptyIfUndefined(data.propPrecip, "%"),
+            chanceOfPrecip: emptyIfUndefined(data.propPrecip, "%"),
             humidity: emptyIfUndefined(data.humidity, "%"),
             sunrise: data.sunrise || sunrise.toLocaleTimeString(Qt.locale().name, options),
             sunset: data.sunset || sunset.toLocaleTimeString(Qt.locale().name, options),

=== modified file 'debian/changelog'
--- debian/changelog	2015-12-03 15:22:45 +0000
+++ debian/changelog	2015-12-12 03:43:31 +0000
@@ -1,7 +1,11 @@
 ubuntu-weather-app (3.2) UNRELEASED; urgency=medium
 
+  [ Andrew Hayzen ]
   * Release 3.1 and bump version to 3.2
 
+  [ Victor Thompson ]
+  * Change translatable string from "rain" to "precipitation" (LP:1521701)
+
  -- Andrew Hayzen <ahayzen@xxxxxxxxx>  Thu, 03 Dec 2015 15:20:49 +0000
 
 ubuntu-weather-app (3.1ubuntu1) vivid; urgency=medium

=== modified file 'po/com.ubuntu.weather.pot'
--- po/com.ubuntu.weather.pot	2015-11-26 02:05:13 +0000
+++ po/com.ubuntu.weather.pot	2015-12-12 03:43:31 +0000
@@ -8,7 +8,7 @@
 msgstr ""
 "Project-Id-Version: ubuntu-weather-app\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2015-11-26 02:04+0000\n"
+"POT-Creation-Date: 2015-12-11 21:39-0600\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <LL@xxxxxx>\n"
@@ -19,7 +19,7 @@
 "Plural-Forms: nplurals=INTEGER; plural=EXPRESSION;\n"
 
 #: ../app/components/DayDelegateExtraInfo.qml:52
-msgid "Chance of rain"
+msgid "Chance of precipitation"
 msgstr ""
 
 #: ../app/components/DayDelegateExtraInfo.qml:59