ubuntu-touch-coreapps-reviewers team mailing list archive

[Nicholas Skaggs <nskaggs@xxxxxxxxxx>]

Nicholas Skaggs has proposed merging lp:~nskaggs/ubuntu-clock-app/manual-tests-from-pilot into lp:ubuntu-clock-app.

Commit message:
Merge back the tweaks needed for Pilot to the manual tests

Requested reviews:
  Ubuntu Clock Developers (ubuntu-clock-dev)

For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-clock-app/manual-tests-from-pilot/+merge/280779

Merge back the tweaks needed for Pilot to the manual tests
-- 
Your team Ubuntu Clock Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-clock-app/manual-tests-from-pilot into lp:ubuntu-clock-app.

=== renamed file 'tests/manual/2014.com.ubuntu.clock:clock-tests/jobs/alarms.pxu' => 'tests/manual/2014.com.ubuntu.clock:clock-tests/jobs/clock-alarms.pxu' (properties changed: -x to +x)
--- tests/manual/2014.com.ubuntu.clock:clock-tests/jobs/alarms.pxu	2015-08-23 00:32:24 +0000
+++ tests/manual/2014.com.ubuntu.clock:clock-tests/jobs/clock-alarms.pxu	2015-12-16 22:30:29 +0000
@@ -1,6 +1,13 @@
-id: alarm/trigger-alarm
+plugin: resource
+id: clock-alarm/system-image
+_summary: [Automated] gather system information
+command: system-image-cli -i
+_description:
+ Gather system info
+
+id: clock-alarm/trigger-alarm
 plugin: manual
-_summary: Trigger alarm test 
+_summary: Trigger alarm test
 estimated_duration: 120
 _description:
     This test checks if an alarm is triggered at the correct time by the datetime indicator.
@@ -13,14 +20,14 @@
        minute. Do not change any other options. Save Alarm.
         The saved alarm should be displayed in the alarms page.
     4. Wait for the alarm to ring.
-        The alarm should ring (with haptic feedback) at the time set in the previous step and 
+        The alarm should ring (with haptic feedback) at the time set in the previous step and
         should show a notification with the buttons "Snooze" and "Ok".
     5. Press "Ok" to dismiss the alarm.
         The alarm should be dismissed.
 
-id: alarm/edit-alarm-sound
+id: clock-alarm/edit-alarm-sound
 plugin: manual
-depends: alarm/trigger-alarm
+depends: clock-alarm/trigger-alarm
 _summary: Edit alarm sound test
 estimated_duration: 120
 _description:
@@ -44,14 +51,14 @@
     7. Press the back button and then save the alarm.
         You should be taken back to the alarms page after you save the alarm.
     8. Wait for the alarm to ring.
-        The alarm should ring (with haptic feedback) at the time set in the previous step and 
+        The alarm should ring (with haptic feedback) at the time set in the previous step and
         should show a notification with the buttons "Snooze" and "Ok".
     9. Press "Ok" to dismiss the alarm.
         The alarm should be dismissed.
 
-id: alarm/edit-alarm-focus
+id: clock-alarm/edit-alarm-focus
 plugin: manual
-depends: alarm/trigger-alarm
+depends: clock-alarm/trigger-alarm
 _summary: Edit Alarm focus test
 estimated_duration: 660
 _description:
@@ -73,20 +80,20 @@
     7. Change the alarm time to ring in the next minute. Do not change any other options. Save Alarm.
         The saved alarm should be displayed in the alarms page.
     8. Wait for the alarm to ring.
-        The alarm should ring (with haptic feedback) at the time set in the previous step and 
+        The alarm should ring (with haptic feedback) at the time set in the previous step and
         should show a notification with the buttons "Snooze" and "Ok".
     9. Press "Ok" to dismiss the alarm.
         The alarm should be dismissed.
 
-id: alarm/silence-setting
+id: clock-alarm/silence-setting
 plugin: manual
-depends: alarm/trigger-alarm
+depends: clock-alarm/trigger-alarm
 _summary: Alarm Silence after setting test
 estimated_duration: 660
 _description:
     This test checks if the alarm's "silence after" setting is obeyed.
     1. Launch the clock app.
-        Clock app opens showing the current local time. 
+        Clock app opens showing the current local time.
     2. Click the settings icon shown in the top right.
         The settings page is visible showing the alarm settings.
     3. Set the silence after setting to 10 minutes.
@@ -99,23 +106,23 @@
         message being displayed that "No saved alarms".
     6. Press the plus icon to create a new alarm. Change the alarm time to ring in the next
        minute. Do not change any other options. Save Alarm.
-        The saved alarm should be displayed in the alarms page. 
+        The saved alarm should be displayed in the alarms page.
     7. Wait for the alarm to ring.
-        The alarm should ring (with haptic feedback) at the time set in the previous step and 
+        The alarm should ring (with haptic feedback) at the time set in the previous step and
         should show a notification with the buttons "Snooze" and "Ok".
     8. Allow the alarm to keep ringing.
         The alarm should keep ringing and be silenced automatically by the phone only after
         the duration set in step three.
 
-id: alarm/vibration-setting
+id: clock-alarm/vibration-setting
 plugin: manual
-depends: alarm/trigger-alarm
+depends: clock-alarm/trigger-alarm
 _summary: Alarm vibration setting test
 estimated_duration: 120
 _description:
     This test checks if the alarm vibration settings enables/disables the alarm vibration.
     1. Launch the clock app.
-        Clock app opens showing the current local time. 
+        Clock app opens showing the current local time.
     2. Click the settings icon shown in the top right.
         The settings page is visible showing the alarm settings.
     3. Toggle the alarm vibration settings to off position.
@@ -127,22 +134,22 @@
         message being displayed that "No saved alarms".
     6. Press the plus icon to create a new alarm. Change the alarm time to ring in the next
        minute. Do not change any other options. Save Alarm.
-        The saved alarm should be displayed in the alarms page. 
+        The saved alarm should be displayed in the alarms page.
     7. Wait for the alarm to ring.
         Wait for the alarm to ring.
         The alarm should ring at the time set in the previous step and should show a
         notification with the buttons "Snooze" and "Ok". However there should be no
         vibration when the alarm rings.
 
-id: alarm/snooze-setting
+id: clock-alarm/snooze-setting
 plugin: manual
-depends: alarm/trigger-alarm
+depends: clock-alarm/trigger-alarm
 estimated_duration: 360
 _summary: Test the alarm snooze setting options
 _description:
     This test checks if the alarm snooze settings works as expected.
     1. Launch the clock app.
-        Clock app opens showing the current local time. 
+        Clock app opens showing the current local time.
     2. Click the settings icon shown in the top right.
         The settings page is visible showing the alarm settings.
     3. Set the snooze duration to 2 minutes.
@@ -155,9 +162,9 @@
         message being displayed that "No saved alarms".
     6. Press the plus icon to create a new alarm. Change the alarm time to ring in the next
        minute. Do not change any other options. Save Alarm.
-        The saved alarm should be displayed in the alarms page. 
+        The saved alarm should be displayed in the alarms page.
     7. Wait for the alarm to ring.
-        The alarm should ring (with haptic feedback) at the time set in the previous step and 
+        The alarm should ring (with haptic feedback) at the time set in the previous step and
         should show a notification with the buttons "Snooze" and "Ok".
     8. Press the "Snooze" button.
         The alarm should be snoozed.
@@ -165,10 +172,10 @@
         The alarm should ring again (with haptic feedback). Note that if an alarm is set to ring
         originally at 10:00:00 and you snooze it the first time at 10:01:30, it should ring the next
         time at 10:03:30 and not at 10:02:00.
-        
-id: alarm/disable-alarm
+
+id: clock-alarm/disable-alarm
 plugin: manual
-depends: alarm/trigger-alarm
+depends: clock-alarm/trigger-alarm
 estimated_duration: 360
 _summary: Test the alarm disable feature
 _description:
@@ -186,9 +193,9 @@
     5. Wait for the time to pass the alarm time.
         The alarm should not ring since it was disabled.
 
-id: alarm/refresh-one-alarm
+id: clock-alarm/refresh-one-alarm
 plugin: manual
-depends: alarm/trigger-alarm
+depends: clock-alarm/trigger-alarm
 estimated_duration: 120
 _summary: Test the alarm page refresh issue
 _description:
@@ -208,9 +215,9 @@
     6. Check the status of the one-time alarm you just dismissed.
         The one-time alarm must be disabled since it was triggered and dismissed by the user.
 
-id: alarm/refresh-recurring-alarm
+id: clock-alarm/refresh-recurring-alarm
 plugin: manual
-depends: alarm/trigger-alarm
+depends: clock-alarm/trigger-alarm
 estimated_duration: 120
 _summary: Test the alarm switch disable issue
 _description:

=== renamed file 'tests/manual/2014.com.ubuntu.clock:clock-tests/jobs/setting.pxu' => 'tests/manual/2014.com.ubuntu.clock:clock-tests/jobs/clock-setting.pxu' (properties changed: -x to +x)
--- tests/manual/2014.com.ubuntu.clock:clock-tests/jobs/setting.pxu	2014-09-12 17:33:02 +0000
+++ tests/manual/2014.com.ubuntu.clock:clock-tests/jobs/clock-setting.pxu	2015-12-16 22:30:29 +0000
@@ -1,11 +1,18 @@
-id: setting/timezone-change
+plugin: resource
+id: clock-setting/system-image
+_summary: [Automated] gather system information
+command: system-image-cli -i
+_description:
+ Gather system info
+
+id: clock-setting/timezone-change
 plugin: manual
 _summary: Test to check if system timezone change is also done in the clock app
 estimated_duration: 60
 _description:
     Test to check if system timezone change also updates the time in the clock app.
     1. Launch the clock app.
-        Clock app opens showing the current local time. 
+        Clock app opens showing the current local time.
     2. Click the settings icon shown in the top right.
         The settings page is visible showing the alarm settings.
     3. Press the "Change time and date" settings option.
@@ -19,4 +26,4 @@
         the new timezone time.
     6. Press the back button.
         The main clock page is shown and the main clock also shows the new
-        timezone time.   
+        timezone time.

=== renamed file 'tests/manual/2014.com.ubuntu.clock:clock-tests/jobs/stopwatch.pxu' => 'tests/manual/2014.com.ubuntu.clock:clock-tests/jobs/clock-stopwatch.pxu'
--- tests/manual/2014.com.ubuntu.clock:clock-tests/jobs/stopwatch.pxu	2015-09-11 13:13:17 +0000
+++ tests/manual/2014.com.ubuntu.clock:clock-tests/jobs/clock-stopwatch.pxu	2015-12-16 22:30:29 +0000
@@ -1,4 +1,11 @@
-id: stopwatch/language-change
+plugin: resource
+id: clock-stopwatch/system-image
+_summary: [Automated] gather system information
+command: system-image-cli -i
+_description:
+ Gather system info
+
+id: clock-stopwatch/language-change
 plugin: manual
 _summary: Test to check if stopwatch is working properly after timezone change, without closing Stopwatch
 estimated_duration: 600
@@ -11,7 +18,7 @@
     3. Press the Start button.
         The main display starts counting time. The Start button disappears and the buttons Stop and Lap appear.
     4. Press the Lap button.
-        New lap row appears together with the lap header.    
+        New lap row appears together with the lap header.
     5. Switch to the system settings app. Navigate to Date & Time.
         The field with current timezone should be visible. Remember current timezone setting.
     6. Press the current timezone field and change system timezone to something different.

=== renamed file 'tests/manual/2014.com.ubuntu.clock:clock-tests/jobs/worldcity.pxu' => 'tests/manual/2014.com.ubuntu.clock:clock-tests/jobs/clock-worldcity.pxu' (properties changed: -x to +x)
--- tests/manual/2014.com.ubuntu.clock:clock-tests/jobs/worldcity.pxu	2015-09-17 13:05:07 +0000
+++ tests/manual/2014.com.ubuntu.clock:clock-tests/jobs/clock-worldcity.pxu	2015-12-16 22:30:29 +0000
@@ -1,4 +1,11 @@
-id: worldcity/language-change
+plugin: resource
+id: clock-worldcity/system-image
+_summary: [Automated] gather system information
+command: system-image-cli -i
+_description:
+ Gather system info
+
+id: clock-worldcity/language-change
 plugin: manual
 _summary: Test to check if world city language changes when the system language is changed
 estimated_duration: 600

=== modified file 'tests/manual/2014.com.ubuntu.clock:clock-tests/launcher/clock-test-cli'
--- tests/manual/2014.com.ubuntu.clock:clock-tests/launcher/clock-test-cli	2014-09-12 17:10:18 +0000
+++ tests/manual/2014.com.ubuntu.clock:clock-tests/launcher/clock-test-cli	2015-12-16 22:30:29 +0000
@@ -3,19 +3,19 @@
 [welcome]
 text= Welcome to Clock App Manual Tests!
     This application will guide you through some manual test cases which
-    confirm the workings of the Clock application (part of Ubuntu Core 
+    confirm the workings of the Clock application (part of Ubuntu Core
     Applications) and its interaction with the system. The test suites are
-    split into various groups based on their functionality like alarm, 
+    split into various groups based on their functionality like alarm,
     settings etc.
-    
+
     If all the actions produce the expected results listed, please submit
     a 'passed' result.
-    
+
     If an action fails, or produces an unexpected results, please submit a
     'failed' result and file a bug. Please be sure to include the bug number
     when you submit your result.
 
 [suite]
-whitelist_filter = clock-app-.*
+whitelist_filter = clock-.*
 whitelist_selection=.*
 skip_test_selection = True

=== renamed file 'tests/manual/2014.com.ubuntu.clock:clock-tests/whitelists/clock-app-alarm.whitelist' => 'tests/manual/2014.com.ubuntu.clock:clock-tests/whitelists/clock-alarm.whitelist' (properties changed: -x to +x)
--- tests/manual/2014.com.ubuntu.clock:clock-tests/whitelists/clock-app-alarm.whitelist	2014-09-12 13:36:45 +0000
+++ tests/manual/2014.com.ubuntu.clock:clock-tests/whitelists/clock-alarm.whitelist	2015-12-16 22:30:29 +0000
@@ -1,2 +1,2 @@
-alarm/.*
+clock-alarm/.*
 

=== renamed file 'tests/manual/2014.com.ubuntu.clock:clock-tests/whitelists/clock-app-setting.whitelist' => 'tests/manual/2014.com.ubuntu.clock:clock-tests/whitelists/clock-setting.whitelist' (properties changed: -x to +x)
--- tests/manual/2014.com.ubuntu.clock:clock-tests/whitelists/clock-app-setting.whitelist	2014-09-12 13:36:45 +0000
+++ tests/manual/2014.com.ubuntu.clock:clock-tests/whitelists/clock-setting.whitelist	2015-12-16 22:30:29 +0000
@@ -1,1 +1,1 @@
-setting/.*
+clock-setting/.*

=== renamed file 'tests/manual/2014.com.ubuntu.clock:clock-tests/whitelists/clock-app-stopwatch.whitelist' => 'tests/manual/2014.com.ubuntu.clock:clock-tests/whitelists/clock-stopwatch.whitelist'
--- tests/manual/2014.com.ubuntu.clock:clock-tests/whitelists/clock-app-stopwatch.whitelist	2015-09-10 08:49:17 +0000
+++ tests/manual/2014.com.ubuntu.clock:clock-tests/whitelists/clock-stopwatch.whitelist	2015-12-16 22:30:29 +0000
@@ -1,1 +1,1 @@
-stopwatch/.*
+clock-stopwatch/.*

=== renamed file 'tests/manual/2014.com.ubuntu.clock:clock-tests/whitelists/clock-app-worldcity.whitelist' => 'tests/manual/2014.com.ubuntu.clock:clock-tests/whitelists/clock-worldcity.whitelist' (properties changed: -x to +x)
--- tests/manual/2014.com.ubuntu.clock:clock-tests/whitelists/clock-app-worldcity.whitelist	2015-08-23 09:35:44 +0000
+++ tests/manual/2014.com.ubuntu.clock:clock-tests/whitelists/clock-worldcity.whitelist	2015-12-16 22:30:29 +0000
@@ -1,1 +1,1 @@
-worldcity/.*
+clock-worldcity/.*