ubuntu-touch-coreapps-reviewers team mailing list archive

[Bartosz Kosiorek <gang65@xxxxxxxxxxxxxx>]

Bartosz Kosiorek has proposed merging lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-fix-keyboard into lp:ubuntu-calculator-app.

Commit message:
Remove asynchronous loading of virtual keyboard, as it is causing issues with display

Requested reviews:
  Ubuntu Calculator Developers (ubuntu-calculator-dev)

For more details, see:
https://code.launchpad.net/~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-fix-keyboard/+merge/281014

Remove asynchronous loading of virtual keyboard, as it is causing issues with display

-- 
Your team Ubuntu Calculator Developers is requested to review the proposed merge of lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-fix-keyboard into lp:ubuntu-calculator-app.

=== modified file 'app/ubuntu-calculator-app.qml'
--- app/ubuntu-calculator-app.qml	2015-12-20 00:41:53 +0000
+++ app/ubuntu-calculator-app.qml	2015-12-20 00:55:19 +0000
@@ -715,7 +715,6 @@
                 Loader {
                     id: keyboardLoader
                     width: parent.width
-                    asynchronous: true
                     source: scrollableView.width > scrollableView.height ? "ui/LandscapeKeyboard.qml" : "ui/PortraitKeyboard.qml"
                     opacity: ((y + height) >= scrollableView.contentY) &&
                              (y <= (scrollableView.contentY + scrollableView.height)) ? 1 : 0

=== modified file 'ubuntu-calculator-app.apparmor'
--- ubuntu-calculator-app.apparmor	2015-12-20 00:41:53 +0000
+++ ubuntu-calculator-app.apparmor	2015-12-20 00:55:19 +0000
@@ -1,5 +1,6 @@
 {
     "policy_groups": [
+        "networking"
     ],
     "policy_version": 1.3
 }