ubuntu-touch-coreapps-reviewers team mailing list archive

[Andrew Hayzen <ahayzen@xxxxxxxxx>]

Review: Needs Fixing

LGTM, just one comment

1) Could you update the design doc link, as you did with weather?

Diff comments:

> 
> === added file 'README.md'
> --- README.md	1970-01-01 00:00:00 +0000
> +++ README.md	2015-12-18 17:05:23 +0000
> @@ -0,0 +1,25 @@
> +ReadMe - Ubuntu Music App
> +===========================
> +Ubuntu Music App is the official music app for Ubuntu Touch. We follow an open
> +source model where the code is available to anyone to branch and hack on. The
> +ubuntu music app follows a test driven development (TDD) where tests are
> +written in parallel to feature implementation to help spot regressions easier.
> +
> +Dependencies
> +============
> +**DEPENDENCIES ARE NEEDED TO BE INSTALLED TO BUILD AND RUN THE APP**.
> +
> +A complete list of dependencies for the project can be found in music-app/debian/control
> +
> +The following essential packages are also required to develop this app:
> +* [ubuntu-sdk](http://developer.ubuntu.com/start)
> +* intltool   - run  `sudo apt-get install intltool` 
> +
> +Useful Links
> +============
> +Here are some useful links with regards to the Music App development.
> +
> +* [Home Page](https://developer.ubuntu.com/en/community/core-apps/music/)
> +* [Music App Wiki](https://wiki.ubuntu.com/Touch/CoreApps/Music)
> +* [Designs](https://docs.google.com/presentation/d/1L3eGhOe-0eEmKtUurthpUEaweFradSFb3t6W-KiIZMU/edit#slide=id.g3e005603e_420)

Could you update the design doc link, as you did with weather?

> +* [Project page](https://launchpad.net/music-app) 


-- 
https://code.launchpad.net/~emailgirishrawat/music-app/READMEs/+merge/280920
Your team Music App Developers is subscribed to branch lp:music-app.