ubuntu-touch-coreapps-reviewers team mailing list archive

[Bartosz Kosiorek <gang65@xxxxxxxxxxxxxx>]

Bartosz Kosiorek has proposed merging lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-decrease-startup-time into lp:ubuntu-calculator-app.

Commit message:
Decrease Calculator's startup time (LP: #1520554)

Requested reviews:
  Ubuntu Calculator Developers (ubuntu-calculator-dev)

For more details, see:
https://code.launchpad.net/~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-decrease-startup-time/+merge/281184

Decrease Calculator's startup time (LP: #1520554)
-- 
Your team Ubuntu Calculator Developers is requested to review the proposed merge of lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-decrease-startup-time into lp:ubuntu-calculator-app.

=== modified file 'CMakeLists.txt'
--- CMakeLists.txt	2015-07-09 20:39:32 +0000
+++ CMakeLists.txt	2015-12-22 08:56:09 +0000
@@ -33,7 +33,7 @@
 set(MAIN_QML                        ${APP_HARDCODE}.qml)
 set(ICON_FILE                       "${APP_HARDCODE}.png")
 set(DESKTOP_FILE                    "${APP_HARDCODE}.desktop")
-set(APP_VERSION                     2.0)
+set(APP_VERSION                     2.1)
 set(AUTOPILOT_DIR                   ubuntu_calculator_app)
 
 if(CLICK_MODE)

=== modified file 'app/ui/FavouritePage.qml'
--- app/ui/FavouritePage.qml	2015-11-27 16:40:30 +0000
+++ app/ui/FavouritePage.qml	2015-12-22 08:56:09 +0000
@@ -43,7 +43,7 @@
         subTitle: i18n.tr("Swipe calculations to the left\nto mark as favorites")
         iconName: "starred"
         anchors.centerIn: parent
-        visible: calculationHistory.numberOfFavourites == 0;
+        visible: calculationHistory.numberOfFavourites === 0;
     }
 
     ListView {
@@ -52,8 +52,9 @@
         model: calculationHistory.getContents();
 
         delegate: ListItem.Empty {
-            visible: model.isFavourite && model.dbId != -1
-            height: visible ? units.gu(6) : 0
+            visible: model && model.dbId !== -1
+            // To decrease start time, we would like to avoid using "visible" binding
+            height: (model && model.dbId !== -1) ? units.gu(6) : 0
 
             MouseArea {
                 anchors.fill: parent

=== modified file 'debian/changelog'
--- debian/changelog	2015-11-28 21:35:19 +0000
+++ debian/changelog	2015-12-22 08:56:09 +0000
@@ -7,8 +7,9 @@
     with Google Closure (LP: #1520594)
   * Run Calculator in Landscape mode for Desktop (LP: #1468663)
   * Add instruction how to enable profiling (workaround for LP: #1520551) 
+  * Decrease Calculator's startup time (LP: #1520554)
 
- -- Bartosz Kosiorek <gang65@xxxxxxxxxxxxxx>  Thu, 12 Nov 2015 13:28:29 +0100
+ -- Bartosz Kosiorek <gang65@xxxxxxxxxxxxxx>  Tue, 22 Dec 2015 09:52:54 +0100
 
 ubuntu-calculator-app (2.0.233) vivid; urgency=medium