ubuntu-touch-coreapps-reviewers team mailing list archive

[Andrew Hayzen <ahayzen@xxxxxxxxx>]

Review: Needs Fixing

Awesome thanks, look much better, the web links could do with titles next to them though, I've put an example inline comment next to each one that should be updated.

Also I have one other comment for the README-developers.md

'Not sure if we should directly refer to "Vivid Desktop (15.04)", maybe just "Desktop" is better, otherwise this will have to be updated.'

Otherwise this looks good :-)

Diff comments:

> === added file 'README-Autopilot.md'
> --- README-Autopilot.md	1970-01-01 00:00:00 +0000
> +++ README-Autopilot.md	2015-12-23 15:53:06 +0000
> @@ -0,0 +1,52 @@
> +Running Autopilot tests
> +=======================
> +
> +Ubuntu Shorts App follows a test driven development where autopilot tests are
> +run before every merge into trunk. If you are submitting your bugfix/patch to
> +the shorts app, please follow the following steps below to ensure that all tests
> +pass before proposing a merge request.
> +
> +If you are looking for more info about Autopilot or writing AP tests for the
> +shorts app, here are some useful links to help you:
> +
> +* http://developer.ubuntu.com/start/quality

This link could be [Ubuntu - Quality](http://developer.ubuntu.com/start/quality) instead.

> +* https://developer.ubuntu.com/api/autopilot/python/1.5.0/

[Ubuntu - Autopilot](https://developer.ubuntu.com/api/autopilot/python/1.5.0/)

> +
> +For help and options on running tests, see:
> +
> +* https://developer.ubuntu.com/en/start/platform/guides/running-autopilot-tests/

[Autopilot Tests](https://developer.ubuntu.com/en/start/platform/guides/running-autopilot-tests/)

> +
> +Prerequisites
> +=============
> +
> +Install the following autopilot packages required to run the tests,
> +    $ sudo apt-get install python3-autopilot libautopilot-qt ubuntu-ui-toolkit-autopilot python3-autopilot-vis
> +
> +Running tests on the desktop
> +============================
> +
> +Using terminal:
> +
> +*  Branch the shorts app code,
> +    $ bzr branch lp:ubuntu-rssreader-app
> +
> +*  Build the shorts app,
> +    $ mkdir builddir && cd builddir
> +    $ cmake .. && cmake --build . -- -j 3
> +    $ cd ..
> +
> +*  Navigate to the tests/autopilot directory.
> +    $ cd shorts/tests/autopilot
> +
> +*  run all tests.
> +    $ autopilot3 run -vv shorts_app
> +
> +    to list all tests:
> +    $ autopilot3 list shorts_app
> +
> +    To run only one test (for instance: test_add_single_type_alarm_must_add_to_alarm_list in TestAlarm.py):
> +    $ autopilot3 run -vv ubuntu_shorts_app.tests.test_alarm.TestMainWindow.test_add_feed_to_new_topic
> +
> +    Debugging tests using autopilot vis
> +    $ autopilot3 launch -i Qt qmlscene shorts/qml/shorts-app.qml -I shorts
> +    $ autopilot3 vis
> 
> === added file 'README-Developers.md'
> --- README-Developers.md	1970-01-01 00:00:00 +0000
> +++ README-Developers.md	2015-12-23 15:53:06 +0000
> @@ -0,0 +1,78 @@
> +Building and running on Vivid Desktop (15.04)

Not sure if we should directly refer to "Vivid Desktop (15.04)", maybe just "Desktop" is better, otherwise this will have to be updated.

> +=============================================
> +
> +Building and running the Ubuntu Shorts App is quite simple. You will require
> +Ubuntu 15.04 and higher to run on the desktop.
> +
> +   $ bzr branch lp:ubuntu-rssreader-app branch-name
> +   $ cd branch-name
> +   $ mkdir builddir && cd builddir
> +   $ cmake .. && cmake --build . -- -j 3
> +   $ qmlscene ../shorts/qml/shorts-app.qml -I ../shorts/
> +
> +Submitting a patch upstream
> +===========================
> +
> +If you want to submit a bug fix you can do so by branching the code as shown
> +above, implementing the fixes and running to see if it fixed the issue. We also
> +request that you run the Autopilot and Unit tests to check if anything
> +regressed due to the bug fix.
> +
> +If the tests fail, you will have to fix them before your bug fix can be
> +approved and merged into trunk. If the tests pass then commit and push your
> +code by,
> +
> +   $ bzr commit -m "Implemented bug fix" --fixes lp:bug-number
> +   $ bzr push lp:~launchpadid/ubuntu-rssreader-app/branch-name
> +
> +Running Tests
> +=============
> +
> +Please check README.autopilot and README.unittest on how to run the tests.
> +They are quite explanatory and will help you get started.
> +
> +Code Style
> +==========
> +
> +We are trying to use a common code style throughout the code base to maintain
> +uniformity and improve code clarity. Listed below are the code styles guides
> +that will be followed based on the language used.
> +
> +* QML        - http://qt-project.org/doc/qt-5/qml-codingconventions.html 

[QML](http://qt-project.org/doc/qt-5/qml-codingconventions.html)

> +* JS, C++    - https://google-styleguide.googlecode.com/svn/trunk/cppguide.xml

[JS, C++](https://google-styleguide.googlecode.com/svn/trunk/cppguide.xml)

> +* Python     - Code should follow PEP8 and Flake regulations
> +
> +Note: In the QML code convention, ignore the Javascript code section guidelines.
> +So the sections that should be taken into account in the QML conventions are QML 
> +Object Declarations, Grouped Properties and Lists.
> +
> +Debugging
> +=========
> + 
> +GDB allows one to see what is going on `inside' another program while it executes, 
> +or what another program was doing at the moment it crashed. It is a pretty niffty tool which allows you 
> +to get the crash log that can help a developer pin point the cause of the crash.
> +Before reproducing crash it is good to create symbols table for gdb, by using command:
> +
> +   $ cd branch-name
> +   $ mkdir builddir && cd builddir
> +   $ cmake -DCMAKE_BUILD_TYPE=Debug .. && cmake --build . -- -j 3
> +
> +To run GDB:
> +
> +   $ gdb qmlscene
> +
> +At this point, you are inside the gdb prompt. Run your application as you normally would.
> +
> +     run ../shorts/qml/shorts-app.qml -I ../shorts
> +
> +Your app is now running and monitored by GDB. Reproduce the steps in your app to make it crash. Once it does crash,
> +
> +     bt
> +
> +That's about it. To quit GDB, type quit to return back to the normal terminal console.
> +
> +     quit
> +
> +
> +
> 
> === added file 'README-translations.md'
> --- README-translations.md	1970-01-01 00:00:00 +0000
> +++ README-translations.md	2015-12-23 15:53:06 +0000
> @@ -0,0 +1,42 @@
> +Updating translations
> +=====================
> +
> +Translations for the Shorts app happen in [Launchpad Translations] and
> +are automatically committed daily on the trunk branch in the shorts/po/ folder.
> +
> +They are then built and installed as part of the package build, so that
> +developers don't really need to worry about them.
> +
> +However, there is one task that needs to be taken care of: exposing new
> +translatable messages to translators. So whenever you add new translatable
> +messages in the code, make sure to follow these steps:
> +
> + 1. Run click-buddy retaining the build directory:
> +    $ click-buddy --dir . --no-clean
> + 2. Copy the .pot file from the <build dir> mentioned in the output to your
> +    original source:
> +    $ cp <build dir>/shorts/po/*.pot shorts/po/
> + 3. Commit the generated .pot file: 
> +    $ bzr commit -m"Updated translation template"
> + 4. Push the branch and send a merge proposal as usual
> +
> +And that's it, once the branch lands Launchpad should take care of all the rest!
> +
> +Behind the scenes
> +=================
> +
> +Behind the scenes, whenever the shorts/po/*.pot file (also known as translations template)
> +is committed to trunk Launchpad reads it and updates the translatable strings
> +exposed in the web UI. This will enable translators to work on the new strings.
> +The translations template contains all translatable strings that have been
> +extracted from the source code files.
> +
> +Launchpad will then store translations in its database and will commit them daily
> +in the form of textual shorts/po/*.po files to trunk. The PO files are also usually
> +referred to as the translations files. You'll find a translation file for each
> +language the app has got at least a translated message available for.
> +
> +Translations for core apps follow the standard [gettext format].
> +
> + [Launchpad Translations]: https://translations.launchpad.net/ubuntu-rssreader-app

[Launchpad Translations](https://translations.launchpad.net/ubuntu-rssreader-app)

> + [gettext format]: https://www.gnu.org/software/gettext/

[Gettext format](https://www.gnu.org/software/gettext/)

> 
> === added file 'README.md'
> --- README.md	1970-01-01 00:00:00 +0000
> +++ README.md	2015-12-23 15:53:06 +0000
> @@ -0,0 +1,17 @@
> +ReadMe - Ubuntu Shorts App
> +=========================
> +
> +Ubuntu Shorts App is the official rss reader app for Ubuntu Touch. We follow an open
> +source model where the code is available to anyone to branch and hack on. The
> +ubuntu shorts app follows a test driven development (TDD) where tests are
> +written in parallel to feature implementation to help spot regressions easier.
> +
> +Useful Links
> +============
> +
> +Here are some useful links with regards to the Clock App development.
> +
> +* Home Page      - https://developer.ubuntu.com/en/community/core-apps/shorts/

[Home Page](https://developer.ubuntu.com/en/community/core-apps/shorts/)

> +* Project page   - https://launchpad.net/ubuntu-rssreader-app

[Project page](https://launchpad.net/ubuntu-rssreader-app)

> +
> +


-- 
https://code.launchpad.net/~dtrg21/ubuntu-rssreader-app/add-readmes/+merge/281191
Your team Ubuntu Shorts Developers is subscribed to branch lp:ubuntu-rssreader-app.