ubuntu-touch-coreapps-reviewers team mailing list archive

[Stefano Verzegnassi <stefano92.100@xxxxxxxxx>]

Stefano Verzegnassi has proposed merging lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1523112 into lp:ubuntu-docviewer-app.

Commit message:
Added Flickable in DetailsPage. Content can be scrolled when bigger than the page.

Requested reviews:
  Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)
Related bugs:
  Bug #1523112 in Ubuntu Document Viewer App: "Details page can not be scrolled"
  https://bugs.launchpad.net/ubuntu-docviewer-app/+bug/1523112

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/fix-1523112/+merge/281364

Added Flickable in DetailsPage. Content can be scrolled when bigger than the page.
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1523112 into lp:ubuntu-docviewer-app.

=== modified file 'src/app/qml/common/DetailsPage.qml'
--- src/app/qml/common/DetailsPage.qml	2015-10-23 10:46:24 +0000
+++ src/app/qml/common/DetailsPage.qml	2015-12-26 18:46:12 +0000
@@ -24,39 +24,47 @@
     objectName: "detailsPage"
     title: i18n.tr("Details")
 
-    Column {
-        width: Math.min(units.gu(80), parent.width)
-        anchors {
-            top: parent.top
-            bottom: parent.bottom
-            horizontalCenter: parent.horizontalCenter
-        }
-
-        SubtitledListItem {
-            text: i18n.tr("Location")
-            subText: file.path
-        }
-
-        SubtitledListItem {
-            text: i18n.tr("Size")
-            subText: Utils.printSize(i18n, file.info.size)
-        }
-
-        SubtitledListItem {
-            text: i18n.tr("Created")
-            subText: file.info.creationTime.toLocaleString(Qt.locale())
-        }
-
-        SubtitledListItem {
-            text: i18n.tr("Last modified")
-            subText: file.info.lastModified.toLocaleString(Qt.locale())
-        }
-
-        SubtitledListItem {
-            // Used by Autopilot tests
-            objectName: "mimetypeItem"
-            text: i18n.tr("MIME type")
-            subText: file.mimetype.name
+    Flickable {
+        id: flick
+        anchors.fill: parent
+        interactive: true
+
+        contentWidth: parent.width
+        contentHeight: layout.height
+
+        Column {
+            id: layout
+            width: Math.min(units.gu(80), parent.width)
+            anchors.horizontalCenter: parent.horizontalCenter
+
+            SubtitledListItem {
+                text: i18n.tr("Location")
+                subText: file.path
+            }
+
+            SubtitledListItem {
+                text: i18n.tr("Size")
+                subText: Utils.printSize(i18n, file.info.size)
+            }
+
+            SubtitledListItem {
+                text: i18n.tr("Created")
+                subText: file.info.creationTime.toLocaleString(Qt.locale())
+            }
+
+            SubtitledListItem {
+                text: i18n.tr("Last modified")
+                subText: file.info.lastModified.toLocaleString(Qt.locale())
+            }
+
+            SubtitledListItem {
+                // Used by Autopilot tests
+                objectName: "mimetypeItem"
+                text: i18n.tr("MIME type")
+                subText: file.mimetype.name
+            }
         }
     }
+
+    Scrollbar { flickableItem: flick }
 }