ubuntu-touch-coreapps-reviewers team mailing list archive

[Niklas Wenzel <nikwen.developer@xxxxxxxxx>]

Thank you for your contribution!

Please see my inline comment. If you fix it, we can happily merge this. ;)

Diff comments:

> 
> === modified file 'src/app/qml/AuthenticationDialog.qml'
> --- src/app/qml/AuthenticationDialog.qml	2015-07-13 20:25:21 +0000
> +++ src/app/qml/AuthenticationDialog.qml	2015-12-16 23:09:48 +0000
> @@ -37,7 +37,7 @@
>          id: passwordField
>          objectName: "inputField"
>  
> -        placeholderText: i18n.tr("password")
> +        placeholderText: i18n.tr("passcore or passphrase")

There's a small typo in there. ;)

>          echoMode: TextInput.Password
>  
>          onAccepted: okButton.clicked(text)


-- 
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/change_auth_dialog/+merge/280781
Your team Ubuntu Terminal Developers is requested to review the proposed merge of lp:~mcintire-evan/ubuntu-terminal-app/change_auth_dialog into lp:ubuntu-terminal-app.