ubuntu-touch-coreapps-reviewers team mailing list archive

[Victor Thompson <victor.thompson@xxxxxxxxx>]

Review: Needs Fixing

The code for this looks good! I'm not sure however, that we'll want to merge this into the app. The Ubuntu SDK will be introducing scrollbars sometime soon and I think it'd be better to use that feature/component as we'll also want to use it in the Queue and other listviews.

Codewise, I do have 1 inline comment.

Diff comments:

> 
> === modified file 'app/ui/Songs.qml'
> --- app/ui/Songs.qml	2015-10-18 18:16:05 +0000
> +++ app/ui/Songs.qml	2016-01-02 17:05:37 +0000
> @@ -19,6 +19,7 @@
>  
>  import QtQuick 2.4
>  import Ubuntu.Components 1.3
> +import Ubuntu.Components.ListItems 0.1 as ListItem

Should this not be using this version of the UC LIstItems?

>  import Ubuntu.MediaScanner 0.1
>  import Ubuntu.Thumbnailer 0.1
>  import QtMultimedia 5.0


-- 
https://code.launchpad.net/~mcintire-evan/music-app/songs-fastscroll/+merge/281471
Your team Music App Developers is subscribed to branch lp:music-app.