ubuntu-touch-coreapps-reviewers team mailing list archive

[Bartosz Kosiorek <gang65@xxxxxxxxxxxxxx>]

Bartosz Kosiorek has proposed merging lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-bottom-row-fix into lp:ubuntu-calculator-app.

Commit message:
Fix pressing of the bottom row buttons (LP: #1444564)


Requested reviews:
  Ubuntu Calculator Developers (ubuntu-calculator-dev)
Related bugs:
  Bug #1444564 in Ubuntu Calculator App: "Calculator - Bottom row buttons difficult to select in portrait mode"
  https://bugs.launchpad.net/ubuntu-calculator-app/+bug/1444564

For more details, see:
https://code.launchpad.net/~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-bottom-row-fix/+merge/282083

 Fix pressing of the bottom row buttons (LP: #1444564)

-- 
Your team Ubuntu Calculator Developers is requested to review the proposed merge of lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-bottom-row-fix into lp:ubuntu-calculator-app.

=== modified file 'app/upstreamcomponents/PageWithBottomEdge.qml'
--- app/upstreamcomponents/PageWithBottomEdge.qml	2015-11-10 11:52:34 +0000
+++ app/upstreamcomponents/PageWithBottomEdge.qml	2016-01-09 00:17:12 +0000
@@ -229,7 +229,7 @@
             bottom: parent.bottom
 
         }
-        height: bottomEdge.tipHeight
+        height: bottomEdge.tipHeight - units.gu(1.5)
         z: 1
 
         onReleased: {

=== modified file 'debian/changelog'
--- debian/changelog	2015-11-28 21:35:19 +0000
+++ debian/changelog	2016-01-09 00:17:12 +0000
@@ -7,6 +7,7 @@
     with Google Closure (LP: #1520594)
   * Run Calculator in Landscape mode for Desktop (LP: #1468663)
   * Add instruction how to enable profiling (workaround for LP: #1520551) 
+  * Fix pressing of the bottom row buttons (LP: #1444564)
 
  -- Bartosz Kosiorek <gang65@xxxxxxxxxxxxxx>  Thu, 12 Nov 2015 13:28:29 +0100