ubuntu-touch-coreapps-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app

To: Carlos Jose Mazieri <carlos.mazieri@xxxxxxxxx>
From: Arto Jalkanen <ajalkane@xxxxxxxxx>
Date: Sun, 10 Jan 2016 18:59:21 -0000
In-reply-to: <20151212154110.28123.21649.launchpad@ackee.canonical.com>
Reply-to: mp+280387@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve



Diff comments:

> 
> === modified file 'src/plugin/folderlistmodel/diriteminfo.h'
> --- src/plugin/folderlistmodel/diriteminfo.h	2015-09-13 14:20:30 +0000
> +++ src/plugin/folderlistmodel/diriteminfo.h	2015-12-12 15:40:26 +0000
> @@ -108,10 +108,12 @@
>      virtual bool      isBrowsable() const;
>      virtual bool      needsAuthentication() const;
>      virtual QString   authenticationPath() const;
> -    virtual void      setFile(const QString &dir, const QString & file);    
> +    virtual void      setFile(const QString &dir, const QString & file);
> +    virtual void      setFile(const QString &fullname);

fullname -> fullpath ?

>      virtual bool      permission(QFile::Permissions permissions) const;
>      void              fillFromStatBuf(const struct stat& statBuffer);
>      void              setAsHost();
> +    void              setAsShare();
>  
>  public:
>      static QString    removeExtraSlashes(const QString &url, int firstSlashIndex = -1);


-- 
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01/+merge/280387
Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app.