ubuntu-touch-coreapps-reviewers team mailing list archive

[Arto Jalkanen <ajalkane@xxxxxxxxx>]

Review: Approve

Some spelling mistakes in comments

Diff comments:

> 
> === modified file 'src/plugin/folderlistmodel/locationitemdiriterator.h'
> --- src/plugin/folderlistmodel/locationitemdiriterator.h	2015-03-01 15:32:42 +0000
> +++ src/plugin/folderlistmodel/locationitemdiriterator.h	2015-12-12 15:44:23 +0000
> @@ -29,14 +29,22 @@
>   * \brief The LocationItemDirIterator class is an abstract similar to Qt QDirIterator
>   *
>   *   Different protocols supported by filemanager (different Locations) must provide a class like that.
> + *
> + *   The \ref LoadLater can used in the constructor to indicate to the constructor to NOT load the path/url, instead \ref load() can called later to do that.
>   */
>  
>  class LocationItemDirIterator
>  {
>  public:
> +   enum LoadMode
> +   {
> +     LoadOnConstructor,  //!< loads the entire directory or url in the constructor as Qt QDirIterator does
> +     LoadLater           //!< do NOT load the entire directory or url, \ref load() method should be responsabile to do that.

responsabile -> responsible

> +   };
> +
>     virtual ~LocationItemDirIterator();
>  public:
> -   virtual bool	        hasNext()  const = 0;
> +   virtual bool         hasNext()  const = 0;
>     virtual QString	    next()           = 0;
>  
>     virtual DirItemInfo	fileInfo() const = 0;
> @@ -50,18 +58,43 @@
>      * \brief filePath()
>      * \return the full pathname of the current item
>      */
> -   virtual QString	    filePath() const = 0;
> +   virtual QString          filePath() const = 0;
>  
>      /*!
>      * \brief path()
>      * \return  the base directory of the iterator path (not the current item)
>      */
> -   virtual QString	    path()     const = 0;
> -
> -protected:
> -   LocationItemDirIterator(const QString & path, QDirIterator::IteratorFlags flags = QDirIterator::NoIteratorFlags);
> -   LocationItemDirIterator(const QString & path, QDir::Filters filters, QDirIterator::IteratorFlags flags = QDirIterator::NoIteratorFlags);
> -   LocationItemDirIterator(const QString & path, const QStringList & nameFilters, QDir::Filters filters = QDir::NoFilter, QDirIterator::IteratorFlags flags = QDirIterator::NoIteratorFlags);
> +   virtual QString          path()     const;
> +
> +   /*!
> +    * \brief load()  reponsable to load the entire directory or url when \ref LoadLater is passed to the constructor

responsable -> responsible

> +    */
> +   virtual void         load() ;
> +
> +   QDir::Filters        filters()  const;
> +   QDirIterator::IteratorFlags flags() const;
> +
> +protected:
> +   LocationItemDirIterator(const QString & path,
> +                           QDirIterator::IteratorFlags flags = QDirIterator::NoIteratorFlags,
> +                           LocationItemDirIterator::LoadMode loadmode = LocationItemDirIterator::LoadOnConstructor);
> +
> +   LocationItemDirIterator(const QString & path,
> +                           QDir::Filters filters,
> +                           QDirIterator::IteratorFlags flags = QDirIterator::NoIteratorFlags,
> +                           LocationItemDirIterator::LoadMode loadmode = LocationItemDirIterator::LoadOnConstructor);
> +
> +   LocationItemDirIterator(const QString & path,
> +                           const QStringList & nameFilters,
> +                           QDir::Filters filters = QDir::NoFilter,
> +                           QDirIterator::IteratorFlags flags = QDirIterator::NoIteratorFlags,
> +                           LocationItemDirIterator::LoadMode loadmode = LocationItemDirIterator::LoadOnConstructor);
> +
> +protected:
> +   QString                     m_path;
> +   QStringList                 m_nameFilters;
> +   QDir::Filters               m_filters;
> +   QDirIterator::IteratorFlags m_flags;
>  };
>  
>  


-- 
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-02/+merge/280388
Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app.