ubuntu-touch-coreapps-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-fix-autopilot-tests-for-portrait-view into lp:ubuntu-calculator-app

To: mp+282264@xxxxxxxxxxxxxxxxxx
From: Nicholas Skaggs <nskaggs@xxxxxxxxxx>
Date: Tue, 12 Jan 2016 21:44:40 -0000
In-reply-to: <20160112051823.25928.80903.launchpad@ackee.canonical.com>
Reply-to: mp+282264@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

all the failures I see seem correct. I run the test by hand and it doesn't work as the test says it should. Are you sure the functionality is correct?

run3:10: FAIL: ubuntu_calculator_app.tests.test_main.MainTestCase.test_adding_comma_without_number_on_temp_result
run3:44: FAIL: ubuntu_calculator_app.tests.test_main.MainTestCase.test_simple_calculation_via_keyboard
run3:78: FAIL: ubuntu_calculator_app.tests.test_main.MainTestCase.test_temporarly_result
-- 
https://code.launchpad.net/~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-fix-autopilot-tests-for-portrait-view/+merge/282264
Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app.

References

[Merge] lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-fix-autopilot-tests-for-portrait-view into lp:ubuntu-calculator-app
From: Bartosz Kosiorek, 2016-01-12