ubuntu-touch-coreapps-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~mhall119/ubuntu-docviewer-app/pdf-presentations into lp:ubuntu-docviewer-app

To: Michael Hall <mhall119@xxxxxxxxx>
From: Stefano Verzegnassi <stefano92.100@xxxxxxxxx>
Date: Thu, 14 Jan 2016 14:08:17 -0000
In-reply-to: <20160113215624.24729.59500.launchpad@ackee.canonical.com>
Reply-to: mp+282512@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

LGTM!

Just a last question:
I saw you added a back action to Page.header.leadingActionBar.actions. Did you find some issue?

In theory, PageStack automatically appends the action when the page is pushed into the stack (at least, that's what I see on rc-proposed and my vivid+overlay desktop).
-- 
https://code.launchpad.net/~mhall119/ubuntu-docviewer-app/pdf-presentations/+merge/282512
Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app.

References

[Merge] lp:~mhall119/ubuntu-docviewer-app/pdf-presentations into lp:ubuntu-docviewer-app
From: Michael Hall, 2016-01-13