ubuntu-touch-coreapps-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-lib-cache into lp:ubuntu-docviewer-app

To: Roman Shchekin <mrqtros@xxxxxxxxx>
From: Stefano Verzegnassi <stefano92.100@xxxxxxxxx>
Date: Sat, 16 Jan 2016 17:59:14 -0000
In-reply-to: <20160114193708.30411.86719.launchpad@ackee.canonical.com>
Reply-to: mp+282652@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

It works great, I must approve it! \o/

I have just some doubt about the multi-arch support, since the latest release of 'Ubuntu SDK' has the new "CMake Wizard" which, by default, could assign the same name[1] to the build folder, even if two different kits (e.g. "desktop" and "UbuntuSDK_for_armhf_GCC_ubuntu_sdk_15_04_vivid") are used[2].
Anyway, that's IMHO just a small payback we only need to keep in mind.


[1] <source_folder> + "-build" suffix
[2] Older version always used to append the kit name as suffix
-- 
https://code.launchpad.net/~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-lib-cache/+merge/282652
Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app.