ubuntu-touch-coreapps-reviewers team mailing list archive

[Stefano Verzegnassi <stefano92.100@xxxxxxxxx>]

Stefano Verzegnassi has proposed merging lp:~verzegnassi-stefano/ubuntu-docviewer-app/lo-disable-spell-check into lp:ubuntu-docviewer-app.

Commit message:
Disable spell checking in LibreOffice:

* We don't need it since we don't provide any editing feature
* Our minimal build of LibreOffice doesn't have a full languages support
* In future we'll add a full-screen mode for .pptx/.ppt/.odp documents. Those red lines below the text are just terrible.

Requested reviews:
  Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration
  Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/lo-disable-spell-check/+merge/282875

Disable spell checking in LibreOffice:

* We don't need it since we don't provide any editing feature
* Our minimal build of LibreOffice doesn't have a full languages support
* In future we'll add a full-screen mode for .pptx/.ppt/.odp documents. Those red lines below the text are just terrible.
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/lo-disable-spell-check into lp:ubuntu-docviewer-app.

=== renamed file 'click/disable-file-locking.sh' => 'click/disable-lo-features.sh'
--- click/disable-file-locking.sh	2015-11-17 14:22:16 +0000
+++ click/disable-lo-features.sh	2016-01-17 20:21:54 +0000
@@ -9,3 +9,6 @@
 
 echo "Disable file locking in LibreOffice"
 cp $THIS_DIR/disable-file-locking.xcd $LO_REGISTRY
+
+echo "Disable spell checking in LibreOffice"
+cp $THIS_DIR/disable-spell-check.xcd $LO_REGISTRY

=== added file 'click/disable-spell-check.xcd'
--- click/disable-spell-check.xcd	1970-01-01 00:00:00 +0000
+++ click/disable-spell-check.xcd	2016-01-17 20:21:54 +0000
@@ -0,0 +1,23 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<oor:data xmlns:oor="http://openoffice.org/2001/registry";>
+  <dependency file="main"/>
+  <oor:component-data oor:package="org.openoffice.Office" oor:name="Linguistic">
+    <node oor:name="General">
+        <node oor:name="DictionaryList">
+            <prop oor:name="ActiveDictionaries">
+              <value>IgnoreAllList</value>
+            </prop>
+        </node>
+    </node>
+    <node oor:name="GrammarChecking">
+        <prop oor:name="IsAutoCheck">
+            <value>false</value>
+        </prop>
+    </node>
+    <node oor:name="SpellChecking">
+        <prop oor:name="IsSpellAuto">
+            <value>false</value>
+        </prop>
+    </node>
+  </oor:component-data>
+</oor:data>

=== modified file 'cmake/modules/Click.cmake'
--- cmake/modules/Click.cmake	2016-01-14 19:35:11 +0000
+++ cmake/modules/Click.cmake	2016-01-17 20:21:54 +0000
@@ -14,7 +14,7 @@
   # If running in CLICK_MODE, include binary dependencies of docviewer
   set(GET_CLICK_DEPS_TOOL ${CMAKE_SOURCE_DIR}/tools/get-click-deps)
   set(DEPS_MANIFEST ${CMAKE_CURRENT_SOURCE_DIR}/click/docviewer-libs.json)
-  set(CUSTOM_SCRIPT ${CMAKE_CURRENT_SOURCE_DIR}/click/disable-file-locking.sh)
+  set(CUSTOM_SCRIPT ${CMAKE_CURRENT_SOURCE_DIR}/click/disable-lo-features.sh)
   set(UPSTREAM_LIBS_DIR ${CMAKE_BINARY_DIR}/upstream-libs)
 
   MESSAGE("Grabbing upstream libs to ${UPSTREAM_LIBS_DIR}")