← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~popey/ubuntu-terminal-app/add-control into lp:ubuntu-terminal-app

To: Alan Pope  <alan@xxxxxxxxxx>
From: Evan McIntire <mcintire.evan@xxxxxxxxx>
Date: Mon, 18 Jan 2016 19:45:44 -0000
In-reply-to: <20160112095923.9812.44389.launchpad@ackee.canonical.com>
Reply-to: mp+282280@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Actually, changing my review based on what Victor said, there should be some sort of visible indicator that CTRL is toggled, it might be confusing otherwise


-- 
https://code.launchpad.net/~popey/ubuntu-terminal-app/add-control/+merge/282280
Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app.

References

[Merge] lp:~popey/ubuntu-terminal-app/add-control into lp:ubuntu-terminal-app
From: Alan Pope , 2016-01-12